Skip to content

[Tooling] Fix finalize_release lane and options parameter not needed anymore #11850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Jun 28, 2024

Fix CI failure https://buildkite.com/automattic/woocommerce-android/builds/21844#01905ff4-c8af-4766-b7f7-4c5a88004ba5/225-274

(Issue introduced after our recent cleanup from 49758d5 / #11726 hence why it's new)

@AliSoftware AliSoftware added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jun 28, 2024
@AliSoftware AliSoftware added this to the 19.2 ❄️ milestone Jun 28, 2024
@AliSoftware AliSoftware requested review from ThomazFB and iangmaia June 28, 2024 17:53
@AliSoftware AliSoftware self-assigned this Jun 28, 2024
@AliSoftware AliSoftware changed the title Fix finalize_release lane and options parameter not needed anymore [Tooling] Fix finalize_release lane and options parameter not needed anymore Jun 28, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 19.2 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit05c863f
Direct Downloadwoocommerce-wear-prototype-build-pr11850-05c863f.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit05c863f
Direct Downloadwoocommerce-prototype-build-pr11850-05c863f.apk

@ThomazFB ThomazFB merged commit ad01af3 into release/19.2 Jun 28, 2024
14 checks passed
@ThomazFB ThomazFB deleted the tooling/fix-finalize_release branch June 28, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants