Skip to content

Play Store Listing: Update for Wear app #11820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Jun 26, 2024

Why?

The Play Store Listing was initially rejected when we asked to enable the Wear app because the full description didn't mention the Wear app.

How?

We updated the listing manually in Play Store Console and resubmitted it, but for those changes to stick:

What's Next

Once this PR is merged into release/19.2, we need to backmerge release/19.2 into trunk so that the updated PlayStoreStrings.pot reaches trunk and gets picked up by the WPCOM job to be sent to Glotpress for translation.

Testing: only during Production build submission

During the next submission of the production release (cc @ThomazFB), we need to ensure that the en-US Play Store Listing shown in Play Store Console will still contain the added mention of the Wear app (i.e. that it hasn't been reverted by fastlane updating the metadata with an older copy).

Additionally, if translations for the new Play Store Listing copy have already been done in GlotPress, they should be downloaded during the call to finalize_release. We might thus want to check that the Play Store Listing for those locales in Play Store Console has been updated accordingly too once the CI have created the Play Store Release for Production Track after that call.

@AliSoftware AliSoftware added category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. category: releases For PRs that merge a `release/*` branch into `develop` or `trunk`. labels Jun 26, 2024
@AliSoftware AliSoftware added this to the 19.2 ❄️ milestone Jun 26, 2024
@AliSoftware AliSoftware requested review from iangmaia, ThomazFB and a team June 26, 2024 11:49
@AliSoftware AliSoftware self-assigned this Jun 26, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 26, 2024

1 Warning
⚠️ This PR is assigned to the milestone 19.2. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 26, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9d11644
Direct Downloadwoocommerce-wear-prototype-build-pr11820-9d11644.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 26, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9d11644
Direct Downloadwoocommerce-prototype-build-pr11820-9d11644.apk

@@ -17,6 +17,9 @@ Now that you’re actively selling, never miss an order or a review. Keep yourse
Track sales and bestselling products
See which products are winning at a glance. Keep tabs on your overall revenue, order count, and visitor data by week, month, and year. Knowledge = power.

WooCommerce on your watch
Effortlessly view today’s store data and track your orders right from your wrist with our WooCommerce Wear OS App.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomazFB I took the liberty to change the wording from WearOS to Wear OS because that's how they spell it in the Guidelines and I feel like misnaming it WearOS might make the Google reviewers trigger-happy on rejecting it 😅

@@ -1,5 +0,0 @@
<en-US>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused seeing this as I was pretty sure we removed it, but it seems it came back in a merge (fc13979). Thanks for noticing and removing it 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was sure we already removed it as well so was confused why it was still there 😅 Nice catch finding the reason being a merge, that explains it 👍

@AliSoftware
Copy link
Contributor Author

Update: since Google Play requires that we mention Wear OS in all our localized Play Store Listing too (and not just the English one), we'll have to update the fastlane/metadata/android/{locale}/full_description.txt of all the supported locales to include them in the submission.

Our plan is to:

  • Update those localized .txt files in this PR, using Google Translate or ChatGPT to generate the translation of the added paragraph
  • Call fastlane to upload the content of those .txt files to Google Play as the localized Play Store Listings, then submit them for review (ping me once you're at that stage)
  • If the listings get rejected, make the necessary adjustments in the .txt files and iterate
  • Once the new listing gets approved, ensure the .pot is still up-to-date with any potential change we'd have made to the English .txt to make Google happy, then merge this PR to release/19.2 then backmerge release/19.2 all the way to trunk, so that the PlayStoreListing.pot file gets picked up and uploaded to GlotPress
  • Once the new original copy appears in GlotPress (which can take some time depending on when the cron job importing the .pot runs), optionally copy our updated translations from the .txt to GlotPress for each locale, so that they're in sync.
    • Otherwise there's a risk that either the content of the .txt files will be overwritten by the old translations from GlotPress, or that our automation will skip that locale because the translation would be marked status: fuzzy (and not status: current) in GlotPress and would not be exported… which would risk fastlane defaulting to the English translation for those locales (instead of keeping our manually-updated one)

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Jun 26, 2024

FYI, I just ran the following fastlane command from this PR's branch to upload the new content of all the fastlane/metadata/android/*/*.txt files to Google Play:

bundle exec fastlane run upload_to_play_store package_name:com.woocommerce.android \
  skip_upload_metadata:false \
  skip_upload_changelogs:true \
  skip_upload_images:true \
  skip_upload_screenshots:true \
  skip_upload_apk:true skip_upload_aab:true \
  json_key:$HOME/.configure/woocommerce-android/secrets/google-upload-credentials.json

I then confirmed that the new copies sent for submission were now the expected ones in Google Play Console (i.e. matching the .txt files, i.e. that the fastlane command worked as expected), so now we wait for Google to hopefully approve them.

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Jun 26, 2024

Next Steps once Google approves the current listing (🤞 )

  • Merge this PR to release/19.3
  • Backmerge release/19.3 to trunk, so that PlayStoreStrings.pot gets sent to GlotPress
  • Once new English copy appears in GlotPress(†), copy the translations we created from the .txt files as translations for the new copy in GlotPress (so that .txt files content won't be overwritten by GlotPress content during finalize_release)
  • Prepare a PR to modify fastlane/metadata/android/en-US/full_description.txt once again for 19.3, to add the mention of complications in 19.3's future Play Store Listing, but don't merge it until after 19.2 has been submitted
  • After the submission of 19.2 and before the code freeze of 19.3, merge the PR adding mention of complications to the en-US/full_description.txt, so that it's included in the .pot and send to GlotPress for translation during 19.3's complete_code_freeze and that human translations will start translating the new copy.
  • Optionally ping Team Global in #i18n Slack to ask them to relay to our translation contractors the need for those to be translated in all locales in time for 19.3's submission.

cc @ThomazFB


(†) Depending on the time at which this lands in trunk, we might miss the time at which the cron job runs and might wait a couple of hours until the next run happens; so it might take some time for the new original to appear in GlotPress

@ThomazFB ThomazFB changed the base branch from release/19.2 to trunk June 28, 2024 19:28
@ThomazFB ThomazFB changed the base branch from trunk to release/19.3 June 28, 2024 20:08
@ThomazFB ThomazFB merged commit 4e2cdf8 into release/19.3 Jul 1, 2024
15 checks passed
@ThomazFB ThomazFB deleted the metadata/update-play-store-listing-for-wear branch July 1, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: releases For PRs that merge a `release/*` branch into `develop` or `trunk`. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants