Skip to content

[Tooling] Fix outdated changelogs removal logic #11780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

iangmaia
Copy link
Contributor

Adding back the fastlane/metadata/*/en-US/changelogs/default.txt files and fixing the Fastlane logic that tries to remove instead of keeping them.

@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jun 24, 2024
@iangmaia iangmaia added this to the 19.2 ❄️ milestone Jun 24, 2024
@iangmaia iangmaia requested review from AliSoftware and ThomazFB June 24, 2024 11:29
@iangmaia iangmaia self-assigned this Jun 24, 2024
@iangmaia iangmaia enabled auto-merge June 24, 2024 11:30
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 19.2 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commita348d48
Direct Downloadwoocommerce-wear-prototype-build-pr11780-a348d48.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commita348d48
Direct Downloadwoocommerce-prototype-build-pr11780-a348d48.apk

@iangmaia iangmaia merged commit ee99f1a into release/19.2 Jun 24, 2024
16 checks passed
@iangmaia iangmaia deleted the iangmaia/fix-remove-outdated-changelogs-logic branch June 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants