Skip to content

[Tooling] Fix create_gh_release lane parameters #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

iangmaia
Copy link
Contributor

Fixing the private lane create_gh_release so that it explicitly requires a app: parameter that needs to be used when calling it, also updating it on the required call sites.

@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jun 24, 2024
@iangmaia iangmaia added this to the 19.2 ❄️ milestone Jun 24, 2024
@iangmaia iangmaia requested a review from AliSoftware June 24, 2024 08:34
@iangmaia iangmaia self-assigned this Jun 24, 2024
@iangmaia iangmaia changed the title [Tooling[ Fix create_gh_release lane parameters [Tooling] Fix create_gh_release lane parameters Jun 24, 2024
@iangmaia iangmaia requested a review from ThomazFB June 24, 2024 08:35
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 24, 2024

1 Warning
⚠️ This PR is assigned to the milestone 19.2 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 24, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5f4b1fc
Direct Downloadwoocommerce-wear-prototype-build-pr11772-5f4b1fc.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 24, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5f4b1fc
Direct Downloadwoocommerce-prototype-build-pr11772-5f4b1fc.apk

@iangmaia iangmaia enabled auto-merge June 24, 2024 08:48
@iangmaia iangmaia force-pushed the iangmaia/fix-create_gh_release-lane branch from 79f902b to 5f4b1fc Compare June 24, 2024 08:49
@iangmaia iangmaia merged commit 0bafba7 into release/19.2 Jun 24, 2024
15 checks passed
@iangmaia iangmaia deleted the iangmaia/fix-create_gh_release-lane branch June 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants