Skip to content

Shipping lines design recommendations #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Jun 18, 2024

Closes: #11637

Description

This PR fixes the design recommendations from the Shipping lines project

I think we should show the banner above the total section – but we should auto-close the total section when the “Add shipping” sheet is shown. This way we avoid what’s happening in your second image. Showing it on top of the Collect Payment button would block access to it, and potentially cause accidental taps if we make the banner auto-hide.

Either way, I think adding an icon next to the link calls attention a little more.

image

Testing information

  1. Open the app
  2. Navigate to orders
  3. Tap on Add new order (+)
  4. Add a product to enable the shipping section
  5. Tapp on Add shipping
  6. Add a shipping line
  7. Check that the feedback banner is shown on top of the Orders Total section
  8. Check that the feedback banner CTA contains the material review icon
  9. Check that expanding the total section collapses the feedback banner

Images/gif

Screen_recording_20240617_175233.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: task An internally driven task. feature: order creation Related to the Order Creation feature labels Jun 18, 2024
@atorresveiga atorresveiga added this to the 19.2 milestone Jun 18, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitd276974
Direct Downloadwoocommerce-prototype-build-pr11740-d276974.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 40.25%. Comparing base (7028982) to head (d276974).

Files Patch % Lines
...s/creation/totals/OrderCreateEditTotalsFullView.kt 0.00% 10 Missing ⚠️
...rce/android/ui/compose/component/FeedbackDialog.kt 0.00% 6 Missing ⚠️
...oid/ui/orders/creation/OrderCreateEditViewModel.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11740      +/-   ##
============================================
- Coverage     40.25%   40.25%   -0.01%     
  Complexity     5329     5329              
============================================
  Files          1132     1132              
  Lines         65214    65224      +10     
  Branches       9042     9045       +3     
============================================
+ Hits          26250    26254       +4     
- Misses        36549    36554       +5     
- Partials       2415     2416       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit 69da74e into trunk Jun 18, 2024
15 of 16 checks passed
@atorresveiga atorresveiga deleted the issue/11637-shipping-lines-design-recommendations branch June 18, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation Related to the Order Creation feature type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design recommendations
3 participants