Skip to content

[UI Tests] - Run tests on tablet device locally #11695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 19, 2024

Conversation

jostnes
Copy link
Contributor

@jostnes jostnes commented Jun 7, 2024

Description

This PR updates the UI tests so that the tests would also work on a tablet/split screen feature. The tests currently only run locally, and not in CI; the changes to add a new Buildkite step so that this also runs in CI will be done separately.

Testing information

To test, run all UI tests on a tablet emulator locally, and the tests should work as expected. This is the combination I'm using locally:
image

I also tested running the tests in Firebase Test Lab by starting it locally from Android Studio.

The existing instrumented tests should also not be affected by the changes and should remain 🟢 .

Images/gif

N/A

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 7, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit9475254
Direct Downloadwoocommerce-prototype-build-pr11695-9475254.apk

@jostnes jostnes marked this pull request as ready for review June 7, 2024 07:08
@jostnes jostnes requested a review from a team as a code owner June 7, 2024 07:08
@jostnes jostnes added the category: ui tests Related to UI testing. label Jun 7, 2024
@jostnes jostnes added this to the 19.1 milestone Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.23%. Comparing base (f040b34) to head (9475254).
Report is 11 commits behind head on trunk.

Files Patch % Lines
...rc/main/kotlin/com/woocommerce/android/AppPrefs.kt 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11695      +/-   ##
============================================
- Coverage     40.24%   40.23%   -0.01%     
  Complexity     5331     5331              
============================================
  Files          1132     1132              
  Lines         65288    65296       +8     
  Branches       9056     9056              
============================================
  Hits          26273    26273              
- Misses        36594    36602       +8     
  Partials       2421     2421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jostnes jostnes modified the milestones: 19.1, 19.2 Jun 12, 2024
@jostnes jostnes modified the milestones: 19.2, 19.3 Jun 18, 2024
Copy link
Contributor

@tiagomar tiagomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Tests are passing in FTL. :shipit:

@jostnes jostnes modified the milestones: 19.3, 19.2 Jun 19, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 19.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@jostnes jostnes merged commit e873b32 into trunk Jun 19, 2024
16 checks passed
@jostnes jostnes deleted the jostnes/make-tests-run-on-tablet branch June 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ui tests Related to UI testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants