-
Notifications
You must be signed in to change notification settings - Fork 132
[Payment Method Improvements] Remove Feature Flag and related old code #11652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11652 +/- ##
=========================================
Coverage 40.24% 40.25%
+ Complexity 5331 5329 -2
=========================================
Files 1132 1131 -1
Lines 65288 65267 -21
Branches 9056 9052 -4
=========================================
- Hits 26273 26271 -2
+ Misses 36594 36576 -18
+ Partials 2421 2420 -1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes: #11625
Description
This PR removes the feature flag and related old code pertaining to cash payments. Specifically, it removes the
OtherPaymentMethodsEnabled
class as well as all deprecated cash collection code, including dialogs and associated tests. These changes are required to clean up the codebase and prepare for the next release, ensuring that only relevant and up-to-date code remains.Steps to reproduce
Testing information
Devices Used
Testing Scenarios
Areas Not Tested
Images/gif
N/A
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Feel free to adjust any specific parts as needed!