Skip to content

[Payment Method Improvements] Remove Feature Flag and related old code #11652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

backwardstruck
Copy link
Contributor

Closes: #11625

Description

This PR removes the feature flag and related old code pertaining to cash payments. Specifically, it removes the OtherPaymentMethodsEnabled class as well as all deprecated cash collection code, including dialogs and associated tests. These changes are required to clean up the codebase and prepare for the next release, ensuring that only relevant and up-to-date code remains.

Steps to reproduce

  1. Run the app and navigate to the select payment method screen when paying for an open order.
  2. Select "Cash"
  3. Ensure that no remnants of the "OtherPaymentMethodsEnabled" class or related cash collection code are present.
  4. Verify that the functionality aligns with the expectations and no deprecated dialogs appear.

Testing information

Devices Used

  • Tablet emulator
  • Physical device

Testing Scenarios

  • Confirm the removal of the feature flag and related classes from the codebase.
  • Ensure all tests pass and no deprecated dialogs are shown during payment method selection.

Areas Not Tested

  • Backend functionality related to payment processing, which is outside the scope of this PR.

Images/gif

N/A

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Feel free to adjust any specific parts as needed!

@backwardstruck backwardstruck added this to the 19.0 milestone Jun 3, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 3, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitb37318b
Direct Downloadwoocommerce-prototype-build-pr11652-b37318b.apk

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.25%. Comparing base (f040b34) to head (b37318b).

Files Patch % Lines
...ts/methodselection/SelectPaymentMethodViewModel.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #11652   +/-   ##
=========================================
  Coverage     40.24%   40.25%           
+ Complexity     5331     5329    -2     
=========================================
  Files          1132     1131    -1     
  Lines         65288    65267   -21     
  Branches       9056     9052    -4     
=========================================
- Hits          26273    26271    -2     
+ Misses        36594    36576   -18     
+ Partials       2421     2420    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backwardstruck backwardstruck added type: enhancement A request for an enhancement. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Jun 4, 2024
@backwardstruck backwardstruck modified the milestones: 19.0, 19.1 Jun 4, 2024
@toupper toupper modified the milestones: 19.1, 19.2 Jun 14, 2024
# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
@backwardstruck backwardstruck marked this pull request as ready for review June 18, 2024 22:29
@backwardstruck backwardstruck requested a review from kidinov June 18, 2024 22:30
@kidinov kidinov self-assigned this Jun 21, 2024
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kidinov kidinov merged commit 55c031b into trunk Jun 21, 2024
14 checks passed
@kidinov kidinov deleted the 11625-remove-ff-and-related-old-code branch June 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Payment Method Improvements] Remove FF and related old code
5 participants