Skip to content

Display feedback survey #11630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2024
Merged

Conversation

atorresveiga
Copy link
Contributor

Closes: #11399

Why

After releasing the new shipping line support feature, we want to collect user feedback.

Description

This pull request includes the logic for navigating to the CrowdSignal survey and for displaying the survey only after the merchant has used the shipping lines functionality, provided that there is a gap of at least 7 days from the last time we requested feedback.

Testing instructions

  1. Open the app
  2. Navigate to the orders tab
  3. Tap on add new order (+)
  4. Add a product to enable the shipping section
  5. Add a new shipping line
  6. Check that the feedback control is displayed
  7. Tap on close or share feedback to close the control
  8. Add/Update/Delete a shipping line
  9. Check that the feedback control is not displayed again (we want the control to be displayed only once)

Images/gif

Screen_recording_20240530_093917.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: task An internally driven task. feature: order creation Related to the Order Creation feature feature: order editing Related to unified order editing. labels May 30, 2024
@atorresveiga atorresveiga added this to the 18.9 milestone May 30, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 30, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.9. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 30, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit6c61ba3
Direct Downloadwoocommerce-prototype-build-pr11630-6c61ba3.apk

Base automatically changed from issue/11398-feedback-ui to trunk May 30, 2024 21:35
@atorresveiga atorresveiga added category: tracks Related to analytics, including Tracks Events. labels May 30, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 39.40%. Comparing base (4f08f77) to head (6c61ba3).

Files Patch % Lines
...oid/ui/orders/creation/OrderCreateEditViewModel.kt 31.81% 15 Missing ⚠️
...src/main/kotlin/com/woocommerce/android/AppUrls.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11630      +/-   ##
============================================
- Coverage     39.41%   39.40%   -0.01%     
- Complexity     5253     5256       +3     
============================================
  Files          1098     1098              
  Lines         64103    64128      +25     
  Branches       8813     8817       +4     
============================================
+ Hits          25264    25271       +7     
- Misses        36511    36528      +17     
- Partials       2328     2329       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit 076aacc into trunk May 30, 2024
15 of 16 checks passed
@atorresveiga atorresveiga deleted the issue/11399-display-feedback-survey branch May 30, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: order creation Related to the Order Creation feature feature: order editing Related to unified order editing. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic to navigate to the crowsignal survey
4 participants