-
Notifications
You must be signed in to change notification settings - Fork 132
Shipping Lines Feedback UI #11620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Shipping Lines Feedback UI #11620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11620 +/- ##
============================================
- Coverage 39.41% 39.40% -0.01%
- Complexity 5242 5246 +4
============================================
Files 1096 1097 +1
Lines 64036 64095 +59
Branches 8802 8813 +11
============================================
+ Hits 25238 25259 +21
- Misses 36469 36506 +37
- Partials 2329 2330 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: order creation
Related to the Order Creation feature
feature: order editing
Related to unified order editing.
type: task
An internally driven task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11398
Why
After releasing the new shipping line support feature, we want to collect user feedback.
Description
This PR adds the
FeedbackDialog
control, which displays the shipping lines' feedback. The PR only handles the UI and animations. This PR also ensures that the logic to display the shipping lines is executed only once after a change in the order's shipping lines. The logic to display the shipping line and the links to the crowdsignal will be added in a different PR.Testing instructions
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.