Skip to content

Shipping Lines Feedback UI #11620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2024
Merged

Shipping Lines Feedback UI #11620

merged 6 commits into from
May 30, 2024

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented May 30, 2024

Closes: #11398

Why

After releasing the new shipping line support feature, we want to collect user feedback.

Description

This PR adds the FeedbackDialog control, which displays the shipping lines' feedback. The PR only handles the UI and animations. This PR also ensures that the logic to display the shipping lines is executed only once after a change in the order's shipping lines. The logic to display the shipping line and the links to the crowdsignal will be added in a different PR.

Testing instructions

  1. Open the app
  2. Navigate to the orders tab
  3. Tap on add new order (+)
  4. Add a product to enable the shipping section
  5. Add a new shipping line
  6. Check that the feedback control is displayed
  7. Tap on close or share feedback to close the control
  8. Add/Update/Delete a shipping line
  9. Check that the feedback control is not displayed again (we want the control to be displayed only once)

Images/gif

Light Mode Dark Mode
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: task An internally driven task. feature: order creation Related to the Order Creation feature feature: order editing Related to unified order editing. labels May 30, 2024
@atorresveiga atorresveiga changed the title Feedback UI Shipping Lines Feedback UI May 30, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 30, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.9. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@atorresveiga atorresveiga added this to the 18.9 milestone May 30, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 30, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit28e567e
Direct Downloadwoocommerce-prototype-build-pr11620-28e567e.apk

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

Attention: Patch coverage is 28.33333% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 39.40%. Comparing base (5ecf217) to head (28e567e).

Files Patch % Lines
...rce/android/ui/compose/component/FeedbackDialog.kt 0.00% 42 Missing ⚠️
...kotlin/com/woocommerce/android/util/FeatureFlag.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11620      +/-   ##
============================================
- Coverage     39.41%   39.40%   -0.01%     
- Complexity     5242     5246       +4     
============================================
  Files          1096     1097       +1     
  Lines         64036    64095      +59     
  Branches       8802     8813      +11     
============================================
+ Hits          25238    25259      +21     
- Misses        36469    36506      +37     
- Partials       2329     2330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit 4f08f77 into trunk May 30, 2024
14 checks passed
@atorresveiga atorresveiga deleted the issue/11398-feedback-ui branch May 30, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation Related to the Order Creation feature feature: order editing Related to unified order editing. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for the new Shipping survey
4 participants