Return the category from the API result rather than getting it from the DB #11614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeMucientes
commented
May 29, 2024
Comment on lines
-152
to
-153
| val addedCategory = productCategoriesRepository | ||
| .getProductCategoryByNameAndParentId(categoryNameTrimmed, parentId) |
There was a problem hiding this comment.
We already have the new or edited category from the API result, so I think we can safely remove this access to the database, which is the one leading to the crash. The code is now null safe.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11614 +/- ##
=========================================
Coverage 40.24% 40.24%
Complexity 5202 5202
=========================================
Files 1089 1089
Lines 63462 63459 -3
Branches 8711 8711
=========================================
Hits 25539 25539
+ Misses 35619 35616 -3
Partials 2304 2304 ☔ View full report in Codecov by Sentry. |
0nko
approved these changes
May 29, 2024
Comment on lines
-152
to
-153
| val addedCategory = productCategoriesRepository | ||
| .getProductCategoryByNameAndParentId(categoryNameTrimmed, parentId) |
0nko
deleted the
fix/avoid-nullpointer-exception-when-adding-edit-categories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix this crash: #11210
Description
I wasn't able to reproduce the crash but I've made the code nullably safe and removed a DB access that I'm not sure why was it there in the first place. I think is a leftover from legacy implementation that I missed refactoring when I added the edit and remove functionality.
Testing instructions
Smoke test product category feature: