-
Notifications
You must be signed in to change notification settings - Fork 132
[Payment Method Improvements] Add more tests #11607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #11607 +/- ##
=========================================
Coverage 39.32% 39.32%
- Complexity 5225 5232 +7
=========================================
Files 1096 1097 +1
Lines 63984 63992 +8
Branches 8797 8797
=========================================
+ Hits 25160 25165 +5
- Misses 36501 36506 +5
+ Partials 2323 2321 -2 ☔ View full report in Codecov by Sentry. |
Working on resolving the conflicts with the target branch... |
…update-tests # Conflicts: # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorViewModelTest.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please test that all once again as the changes I was doing a bit in a rush as I am quite overwhelmed with the pos?
Then you can just change the feature flag. But please do not forget to remove feature flag, OtherPaymentMethodsEnabled
class and all the "old" cash collection code - dialog/tests and so on in the following PR (can be merged to the next release)
Sure! I created this ticket for that code removal: Testing now. And changing the FF value to |
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
Closes: #11542
This PR is branched off of #11606
Description
Add more unit tests to increase test coverage.
Testing instructions
Unit tests should pass
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.