Skip to content

UI M1 fixes #11605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2024
Merged

UI M1 fixes #11605

merged 4 commits into from
May 29, 2024

Conversation

atorresveiga
Copy link
Contributor

Closes: #11603

Description

This PR fixes some design issues detected during the beta testing of M1

  • The font style should be bold in the Add shipping screen
  • The Remove shipping from order should be red and appear on top of the Add Shipping button
  • Change between Add Shipping or Edit Shipping depending on the flow

Testing instructions

TC1

  1. Open the app
  2. Navigate to the orders tab
  3. Add a new order (+)
  4. Add a product to enable the shipping lines
  5. Add a shipping line
  6. Check that the editable text of the shipping fields is displayed in bold font style
  7. Check that the screen title and button (at the bottom of the screen) display Add Shipping
  8. Save the shipping line

TC2

  1. Using the shipping line from TC1
  2. With the order on create/edit mode, tap on the shipping line
  3. Check that the screen title and button (at the bottom of the screen) display Edit Shipping
  4. Check that the style of the remove button is outlined and using the color red
  5. Check that the editable text of the shipping fields is displayed in bold font style

Images/gif

Add Screen Edit Screen
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: enhancement A request for an enhancement. feature: order creation Related to the Order Creation feature feature: order editing Related to unified order editing. labels May 28, 2024
@atorresveiga atorresveiga added this to the 18.9 milestone May 28, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 28, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitd89854b
Direct Downloadwoocommerce-prototype-build-pr11605-d89854b.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 40.22%. Comparing base (691b6cb) to head (d89854b).

Files Patch % Lines
...ers/creation/shipping/AmountBigDecimalTextField.kt 0.00% 4 Missing ⚠️
...oocommerce/android/ui/compose/component/Buttons.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11605      +/-   ##
============================================
- Coverage     40.22%   40.22%   -0.01%     
- Complexity     5204     5206       +2     
============================================
  Files          1089     1089              
  Lines         63518    63521       +3     
  Branches       8722     8723       +1     
============================================
- Hits          25551    25549       -2     
- Misses        35660    35665       +5     
  Partials       2307     2307              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit 3053334 into trunk May 29, 2024
14 checks passed
@atorresveiga atorresveiga deleted the issue/11603-ui-m1-fixes branch May 29, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation Related to the Order Creation feature feature: order editing Related to unified order editing. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M1 design issues detected
3 participants