Fix date formatting for API requests when using a non-standard numerals system

[hichamboushaba]

Description

While testing how the app's behave when using Arabic language, I found a very serious bug, multiple of our API requests fail, because they send the date formatted using Arabic-Indic numerals, and thus the API calls fails, this impacts the stats card on the dashboard, all of the Analytics Hub cards, and the Products/variations sale dates. This impacts Arabic language, but could also impact other languages.

I updated the logic to use the Locale.ROOT by default when formatting those dates, which fixes the issues:

Before	After

Since this is a serious bug, I'm targeting 18.8 with the fix, but on the other hand, this has been a bug for a very long time, let me know if it's better to update the PR to target 18.9

Testing instructions

1. Set your phone to Arabic-Egypt language.
2. Open the app.
3. Pull-to-refresh the dashboard.
4. Confirm the stats card is working correctly.
5. Optionally: check the Analytics Hub, and the products sale feature (this might not be very straightforward when not knowing Arabic 😄)

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 18.8 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	31d8f99
	Direct Download	woocommerce-prototype-build-pr11596-31d8f99.apk

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.33%. Comparing base (70f75dc) to head (31d8f99).

Additional details and impacted files

@@               Coverage Diff               @@
##             release/18.8   #11596   +/-   ##
===============================================
  Coverage           40.33%   40.33%           
  Complexity           5201     5201           
===============================================
  Files                1087     1087           
  Lines               63226    63227    +1     
  Branches             8666     8666           
===============================================
+ Hits                25501    25502    +1     
  Misses              35431    35431           
  Partials             2294     2294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[0nko]

Nice fix! I've confirmed the stats card and the analytics hub are working without issues 👍