Skip to content

Set the correct event when Blaze campaign is created successfully #11572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024

Conversation

JorgeMucientes
Copy link
Contributor

@JorgeMucientes JorgeMucientes commented May 24, 2024

Description

Fixes an accidental change coming from a wrong merge conflict resolution. The event BLAZE_CAMPAIGN_CREATION_SUCCESS which should be tracked when a Blaze campaign is created, was accidentally overridden by the event BLAZE_CREATION_PAYMENT_SUBMIT_CAMPAIGN_TAPPED which before this fix, is being tracked twice.

Testing instructions

  1. Using a Jetpack connected store with at least 1 product publisjed
  2. Create a Blaze marketing campaign following the steps from the screen recording below
  3. Once the campaign is created successfully, check in Androdi Studio logcat for the following log: 🔵 Tracked: blaze_campaign_creation_success, Properties: ...

Images/gif

BlazeDemo.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

This commit revert and accidental override coming from a bad merge conflict resolution
@dangermattic
Copy link
Collaborator

dangermattic commented May 24, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.7 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@JorgeMucientes JorgeMucientes added category: tracks Related to analytics, including Tracks Events. type: bug A confirmed bug. labels May 24, 2024
@JorgeMucientes JorgeMucientes marked this pull request as ready for review May 24, 2024 13:33
@JorgeMucientes JorgeMucientes added this to the 18.7 ❄️ milestone May 24, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitb8fa927
Direct Downloadwoocommerce-prototype-build-pr11572-b8fa927.apk

@atorresveiga atorresveiga self-assigned this May 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.48%. Comparing base (e4c4baf) to head (b8fa927).
Report is 3 commits behind head on release/18.7.

Files Patch % Lines
...on/payment/BlazeCampaignPaymentSummaryViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/18.7   #11572   +/-   ##
===============================================
  Coverage           40.48%   40.48%           
  Complexity           5197     5197           
===============================================
  Files                1083     1083           
  Lines               62939    62939           
  Branches             8629     8629           
===============================================
  Hits                25481    25481           
  Misses              35164    35164           
  Partials             2294     2294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atorresveiga atorresveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and is working as described. Great work @JorgeMucientes !

🔵 Tracked: blaze_campaign_creation_success, Properties: {"blog_id":222408976,"is_wpcom_store":true,"was_ecommerce_trial":true,"plan_product_slug":"wooexpress-small-bundle-yearly","store_id":"b6468f83-4986-44f1-b4ce-6021649dbf29","is_debug":true,"site_url":"https:\/\/woo-practically-automatic-witch.wpcomstaging.com","cached_woo_core_version":"8.9.1"}

np: I noticed that the event registration and validation are missing. Would you mind taking care of that?
https://mc.a8c.com/tracks/events/event.php?eventname=woocommerceandroid_blaze_campaign_creation_success

@JorgeMucientes JorgeMucientes merged commit a404c79 into release/18.7 May 24, 2024
20 checks passed
@JorgeMucientes JorgeMucientes deleted the fix/wrong-tracking-blaze-success branch May 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants