-
Notifications
You must be signed in to change notification settings - Fork 132
Order create edit shipping lines support #11571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order create edit shipping lines support #11571
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/multiple-shipping-lines-support #11571 +/- ##
===========================================================================
- Coverage 40.44% 40.35% -0.10%
Complexity 5202 5202
===========================================================================
Files 1084 1085 +1
Lines 63090 63201 +111
Branches 8643 8664 +21
===========================================================================
- Hits 25518 25504 -14
- Misses 35273 35397 +124
- Partials 2299 2300 +1 ☔ View full report in Codecov by Sentry. |
c834ca1
into
issue/multiple-shipping-lines-support
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes: #11393
Closes: #11395
Description
This PR introduces a significant enhancement by adding support for multiple shipping lines to the order create/edit flows. This is achieved by incorporating a new shipping section into the order create/edit screen. To display the shipping details, we utilize the current shipping lines field within the order, fetching the shipping method title from the
GetShippingMethodsWithOtherValue
use case. If the method title is not present in the local DB, it is simply not displayed.In addition to displaying shipping lines, I cleaned up all legacy codes of the button interaction for the shipping section in the order totals sheet and the logic to display a warning when there was more than one shipping line.
Finally, I made a slight adjustment to rely on the shipping lines itemId field for the add/update/delete functions so that we can manage the order's shipping lines.
Testing instructions
TC1
TC2
Images/gif
Screen_recording_20240522_163108.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.