-
Notifications
You must be signed in to change notification settings - Fork 132
[Woo POS] Changes to more screen to accomodate entry point to POS #11566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Changes to more screen to accomodate entry point to POS #11566
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
animateAppearance = false | ||
WooThemeWithBackground { | ||
val state = MoreMenuViewState( | ||
menuSections = listOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think MoreMenuViewModelTests
needs to be updated now that generalMenuItems
is now menuSections
:
[2024-05-22T09:45:49Z] e: file:///var/lib/buildkite-agent/builds/ci-cluster-android-i-0b1d9a8e3ea86d90c-1/automattic/woocommerce-android/WooCommerce/src/test/kotlin/com/woocommerce/android/ui/moremenu/MoreMenuViewModelTests.kt:119:44 Unresolved reference: generalMenuItems
```
<br class="Apple-interchange-newline">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, changed that
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11566 +/- ##
============================================
+ Coverage 40.33% 40.34% +0.01%
+ Complexity 5201 5200 -1
============================================
Files 1087 1087
Lines 63226 63247 +21
Branches 8666 8668 +2
============================================
+ Hits 25501 25520 +19
- Misses 35431 35432 +1
- Partials 2294 2295 +1 ☔ View full report in Codecov by Sentry. |
…-and-change-position-for-the-pos-button-in-the-more-screen
@backwardstruck could please take a look again - I've made small changes to look it an Android design (before I actually changed it to an iOS design without realizing it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes: #11545
Description
The PR adds changes to implement an updated UI for the "more" menu screen and adds POS button to it.
As requested by Joe also added "external link" icons for Wp-admin and view store.
The red badge is not implemented here.
Testing instructions
Images/gif
05-22--11-32.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.