Skip to content

[Woo POS] Changes to more screen to accomodate entry point to POS #11566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented May 22, 2024

Closes: #11545

Description

The PR adds changes to implement an updated UI for the "more" menu screen and adds POS button to it.

As requested by Joe also added "external link" icons for Wp-admin and view store.

The red badge is not implemented here.

image

Testing instructions

  • Go to the More screen and make sure there is no changes apart from the UI. Check dark mode. Make sure that all the buttons are in place as they used to be except the POS is on top now

Images/gif

05-22--11-32.mp4
image
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented May 22, 2024

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit987ee79
Direct Downloadwoocommerce-prototype-build-pr11566-987ee79.apk

@kidinov kidinov added this to the 18.8 milestone May 22, 2024
@kidinov kidinov added feature: more menu Related to new Hub Menu tab feature: point of sale POS project labels May 22, 2024
@kidinov kidinov marked this pull request as ready for review May 22, 2024 13:16
@backwardstruck backwardstruck self-assigned this May 22, 2024
Copy link
Contributor

@backwardstruck backwardstruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I'm not seeing the latest code changes, it seems. Maybe you need to push?

Screenshot_20240522_161926

animateAppearance = false
WooThemeWithBackground {
val state = MoreMenuViewState(
menuSections = listOf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think MoreMenuViewModelTests needs to be updated now that generalMenuItems is now menuSections:

[2024-05-22T09:45:49Z] e: file:///var/lib/buildkite-agent/builds/ci-cluster-android-i-0b1d9a8e3ea86d90c-1/automattic/woocommerce-android/WooCommerce/src/test/kotlin/com/woocommerce/android/ui/moremenu/MoreMenuViewModelTests.kt:119:44 Unresolved reference: generalMenuItems
 ```

<br class="Apple-interchange-newline">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, changed that

@backwardstruck backwardstruck modified the milestones: 18.8, 18.9 May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 91.39785% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 40.34%. Comparing base (fd8323d) to head (987ee79).

Files Patch % Lines
...ocommerce/android/ui/moremenu/MoreMenuViewModel.kt 90.58% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11566      +/-   ##
============================================
+ Coverage     40.33%   40.34%   +0.01%     
+ Complexity     5201     5200       -1     
============================================
  Files          1087     1087              
  Lines         63226    63247      +21     
  Branches       8666     8668       +2     
============================================
+ Hits          25501    25520      +19     
- Misses        35431    35432       +1     
- Partials       2294     2295       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kidinov
Copy link
Contributor Author

kidinov commented May 27, 2024

@backwardstruck could please take a look again - I've made small changes to look it an Android design (before I actually changed it to an iOS design without realizing it)

@kidinov kidinov requested a review from backwardstruck May 27, 2024 10:02
Copy link
Contributor

@backwardstruck backwardstruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code changes look good.
Screenshot_20240527_105355

@backwardstruck backwardstruck merged commit d5d0a51 into trunk May 27, 2024
14 checks passed
@backwardstruck backwardstruck deleted the 11545-woo-pos-add-new-red-badge-change-icon-and-change-position-for-the-pos-button-in-the-more-screen branch May 27, 2024 15:01
Copy link

sentry-io bot commented May 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: ANR com.woocommerce.android.util.DeviceFeatures in ... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: more menu Related to new Hub Menu tab feature: point of sale POS project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Add "new" red badge, change icon and change position for the POS button in the "more" screen
5 participants