Skip to content

Shipping lines in order details #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

atorresveiga
Copy link
Contributor

Closes: #11394

Why

As part of Extended Shipping Lines Support, we want to add support for multiple shipping lines.

Description

This PR supports displaying multiple shipping lines in the order details screen. It creates a new shipping section and relies on the cached shipping methods to display the shipping details.

Testing instructions

  1. Open an order with shipping lines
  2. Check that all sipping lines are displayed in the shipping section

Images/gif

Screen_recording_20240518_223212.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: task An internally driven task. feature: order details Related to order details. labels May 20, 2024
@atorresveiga atorresveiga added this to the 18.8 milestone May 20, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 20, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit84d4f66
Direct Downloadwoocommerce-prototype-build-pr11556-84d4f66.apk

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 21.78218% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 40.44%. Comparing base (75b99e8) to head (84d4f66).
Report is 30 commits behind head on issue/multiple-shipping-lines-support.

Files Patch % Lines
...erce/android/ui/orders/details/ShippingLineCard.kt 0.00% 69 Missing ⚠️
.../woocommerce/android/ui/orders/CustomAmountCard.kt 0.00% 6 Missing ⚠️
.../android/ui/orders/details/OrderDetailViewModel.kt 84.61% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##             issue/multiple-shipping-lines-support   #11556      +/-   ##
===========================================================================
- Coverage                                    40.47%   40.44%   -0.03%     
- Complexity                                    5200     5202       +2     
===========================================================================
  Files                                         1083     1084       +1     
  Lines                                        62996    63090      +94     
  Branches                                      8623     8643      +20     
===========================================================================
+ Hits                                         25497    25518      +21     
- Misses                                       35204    35273      +69     
- Partials                                      2295     2299       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga changed the base branch from trunk to issue/multiple-shipping-lines-support May 23, 2024 17:12
@atorresveiga atorresveiga merged commit 888e482 into issue/multiple-shipping-lines-support May 23, 2024
15 checks passed
@atorresveiga atorresveiga deleted the issue/11394-shipping-lines-in-order-details branch May 23, 2024 17:13
Copy link

sentry-io bot commented Jun 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: ANR OrderDetails View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order details Related to order details. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI to display multiple shipping lines Order Details
3 participants