[Payment Method Improvements] AppBar and Navigation for ChangeDueCalculatorFragment

[backwardstruck]

Addresses: #11525

Description

UI improvements for ChangeDueCalculatorFragment to provide a consistent title bar. This is the first PR for the GH issue, which contains other tasks.

Testing instructions

0. Enable OTHER_PAYMENT_METHODS FF
1. Navigate to the cash payment screen
2. Check AppBar Title:
   • Ensure the title is centered and displays dynamic content in various states (e.g., during loading and on displaying success state).
3. Back Button Functionality:
   • Click the back button and verify it navigates to the prior screen correctly across different app states.
4. Rotation Consistency:
   • Ensure that the AppBar works in phone and tablet mode

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[backwardstruck]

@kidinov this is targeted at 18.7 but can go into 18.8 if I don't merge in time.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	46e0e7c
	Direct Download	woocommerce-prototype-build-pr11532-46e0e7c.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.47%. Comparing base (663f191) to head (46e0e7c).
Report is 16 commits behind head on trunk.

Files	Patch %	Lines
...ts/methodselection/ChangeDueCalculatorViewModel.kt	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #11532      +/-   ##
============================================
+ Coverage     40.44%   40.47%   +0.02%     
- Complexity     5197     5201       +4     
============================================
  Files          1083     1083              
  Lines         63001    63006       +5     
  Branches       8635     8635              
============================================
+ Hits          25481    25500      +19     
+ Misses        35226    35210      -16     
- Partials       2294     2296       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kidinov]

Overal lgtm! I left a few suggestions, please take a look

[soundsokay]

If closing the test coverage gap noted by the Codecov Report for ChangeDueCalculatorFragment isn't planned to be addressed in this PR and isn't already covered by a ticket or task please file one as a reminder to get back to this later.

[backwardstruck]

If closing the test coverage gap noted by the Codecov Report for ChangeDueCalculatorFragment isn't planned to be addressed in this PR and isn't already covered by a ticket or task please file one as a reminder to get back to this later.

Yes, I will address those in this ticket as there's more functionality to be added that will also require tests.

[backwardstruck]

Overal lgtm! I left a few suggestions, please take a look

Thanks @kidinov This should be ready for review again now that I've pushed those changes.

[kidinov]

LGTM!

I noticed 2 small things though:

• Too make passing orderId mandatory and have compile time validation you can declare argument as part of the arguments for the fragment:

    <fragment
        android:id="@+id/changeDueCalculatorFragment"
        android:name="com.woocommerce.android.ui.payments.methodselection.ChangeDueCalculatorFragment"
        android:label="ChangeDueCalculatorFragment" >
        <argument
            android:name="orderId"
            app:argType="long" />
    </fragment>

And then in the VM you can get the object with

private val navArgs: ChangeDueCalculatorFragmentArgs by savedStateHandle.navArgs()
navArgs.orderId

And also I noticed that you placed these calses into methodselection package which probably not the most appropriate place for that. I'd go with payments/changeduecalculator

Feel free to address that in the following PRs

[backwardstruck]

Thanks @kidinov those are very good suggestions. Indeed, I forgot to move the classes to changeduecalculator. I will address these in my next PR. They are listed in this new GH issue:

#11553