Save shipping methods locally #11527

atorresveiga · 2024-05-15T22:37:50Z

Description

This PR adds support for caching shipping methods and improves the perceived performance when displaying shipping methods. With these changes, the source of truth will be the local data, and on background, we will refresh the shipping methods info. I also added support for refreshing the info using the pull-to-refresh pattern.

Testing instructions

TC1

Open the app
Go to orders
Tap on add new order (+)
Add a product to enable the the shipping section
Tap on Add shipping
Tap on Select method to navigate to the select method screen
Check that if is the first time that the screen is opened the data is fetched and displayed form a network request
Check that the n time the screen is opened the data is displayed from the DB (on background we make a request to refresh the data)

TC2

Additionally you can test the refresh scenario

Images/gif

Screen_recording_20240515_163546.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

dangermattic · 2024-05-15T22:38:16Z

	1 Warning
⚠️	This PR is assigned to the milestone 18.7. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

wpmobilebot · 2024-05-15T22:59:02Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e311c35`
	Direct Download	`woocommerce-prototype-build-pr11527-e311c35.apk`

codecov-commenter · 2024-05-15T23:12:32Z

Codecov Report

Attention: Patch coverage is 75.80645% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 40.84%. Comparing base (535d184) to head (a9c2c08).
Report is 10 commits behind head on trunk.

❗ Current head a9c2c08 differs from pull request most recent head e311c35. Consider uploading reports for the commit e311c35 to get more accurate results

Files	Patch %	Lines
...creation/shipping/OrderShippingMethodsViewModel.kt	57.69%	8 Missing and 3 partials ⚠️
...ers/creation/shipping/ShippingMethodsRepository.kt	91.30%	0 Missing and 2 partials ⚠️
.../orders/creation/shipping/GetShippingMethodById.kt	66.66%	0 Missing and 1 partial ⚠️
...orders/creation/shipping/RefreshShippingMethods.kt	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #11527      +/-   ##
============================================
+ Coverage     40.46%   40.84%   +0.37%     
+ Complexity     5191     5186       -5     
============================================
  Files          1083     1070      -13     
  Lines         62928    62335     -593     
  Branches       8626     8505     -121     
============================================
- Hits          25466    25461       -5     
+ Misses        35171    34583     -588     
  Partials       2291     2291

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ThomazFB

Amazing work with the database support added here, @atorresveiga! Looks good!

…pping-methods-locally # Conflicts: # build.gradle

wpmobilebot · 2024-05-16T16:31:18Z

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- org.wordpress:fluxc:3008-f3ff9689a0a998537a624ce9a77b930a341bee48
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.7.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:3008-f3ff9689a0a998537a624ce9a77b930a341bee48
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.7.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.22
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
-|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.7.0 (*)
-|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
-|    |    +--- com.google.crypto.tink:tink-android:1.5.0
-|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0 (*)
-|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.2 (*)
-|    +--- androidx.room:room-ktx:2.4.2 -> 2.5.2
-|    |    +--- androidx.room:room-common:2.5.2 (*)
-|    |    +--- androidx.room:room-runtime:2.5.2 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3 (*)
-|    +--- com.google.dagger:dagger:2.42 -> 2.50
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
++--- org.wordpress:fluxc:trunk-14fcce73130015f14125e9e13837f84ff4171bb3
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.7.0 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-14fcce73130015f14125e9e13837f84ff4171bb3
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.7.0 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.22
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
+|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.7.0 (*)
+|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+|    |    +--- com.google.crypto.tink:tink-android:1.5.0
+|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.apache.commons:commons-text:1.10.0 (*)
+|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.2 (*)
+|    +--- androidx.room:room-ktx:2.4.2 -> 2.5.2
+|    |    +--- androidx.room:room-common:2.5.2 (*)
+|    |    +--- androidx.room:room-runtime:2.5.2 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3 (*)
+|    +--- com.google.dagger:dagger:2.42 -> 2.50
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
-\--- org.wordpress.fluxc.plugins:woocommerce:3008-f3ff9689a0a998537a624ce9a77b930a341bee48
-     +--- org.wordpress:wellsql:2.0.0 (*)
-     +--- org.wordpress.fluxc:fluxc-annotations:3008-f3ff9689a0a998537a624ce9a77b930a341bee48
-     +--- androidx.room:room-ktx:2.4.2 -> 2.5.2 (*)
-     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-     +--- org.wordpress:fluxc:3008-f3ff9689a0a998537a624ce9a77b930a341bee48 (*)
-     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-     +--- com.google.dagger:dagger:2.42 -> 2.50 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
-     \--- androidx.room:room-runtime:2.4.2 -> 2.5.2 (*)
+\--- org.wordpress.fluxc.plugins:woocommerce:trunk-14fcce73130015f14125e9e13837f84ff4171bb3
+     +--- org.wordpress:wellsql:2.0.0 (*)
+     +--- org.wordpress.fluxc:fluxc-annotations:trunk-14fcce73130015f14125e9e13837f84ff4171bb3
+     +--- androidx.room:room-ktx:2.4.2 -> 2.5.2 (*)
+     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
+     +--- org.wordpress:fluxc:trunk-14fcce73130015f14125e9e13837f84ff4171bb3 (*)
+     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+     +--- com.google.dagger:dagger:2.42 -> 2.50 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
+     \--- androidx.room:room-runtime:2.4.2 -> 2.5.2 (*)

Please review and act accordingly

Alejo added 8 commits May 14, 2024 19:18

move rest client to fluxC

a90b2a0

add refresh use case

4b8b36e

refactor use new shipping store

300c8cf

cache data and refresh support

dd66a33

fix unit tests

2e0ef43

update FluxC version

5f5f2c8

add refresh unit tests

2b682cd

filter empty db

a9c2c08

atorresveiga added type: enhancement A request for an enhancement. type: task An internally driven task. feature: order creation Related to the Order Creation feature labels May 15, 2024

atorresveiga added this to the 18.7 milestone May 15, 2024

atorresveiga requested a review from ThomazFB May 15, 2024 22:37

atorresveiga changed the title ~~Issue/11515 save shipping methods locally~~ Save shipping methods locally May 15, 2024

atorresveiga mentioned this pull request May 15, 2024

Shipping method db support wordpress-mobile/WordPress-FluxC-Android#3013

Merged

ThomazFB self-assigned this May 16, 2024

ThomazFB approved these changes May 16, 2024

View reviewed changes

Alejo added 2 commits May 16, 2024 10:20

update FluxC version

10e20c9

Merge remote-tracking branch 'origin/trunk' into issue/11515-save-shi…

e311c35

…pping-methods-locally # Conflicts: # build.gradle

atorresveiga enabled auto-merge May 16, 2024 16:25

atorresveiga merged commit 3364eb4 into trunk May 16, 2024
14 checks passed

atorresveiga deleted the issue/11515-save-shipping-methods-locally branch May 16, 2024 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Save shipping methods locally #11527

Save shipping methods locally #11527

Uh oh!

atorresveiga commented May 15, 2024 •

edited

Loading

Uh oh!

dangermattic commented May 15, 2024

Uh oh!

wpmobilebot commented May 15, 2024 •

edited

Loading

Uh oh!

codecov-commenter commented May 15, 2024 •

edited

Loading

Uh oh!

ThomazFB left a comment

Uh oh!

wpmobilebot commented May 16, 2024

Uh oh!

Uh oh!

Uh oh!

Save shipping methods locally #11527

Save shipping methods locally #11527

Uh oh!

Conversation

atorresveiga commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Images/gif

Uh oh!

dangermattic commented May 15, 2024

Uh oh!

wpmobilebot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ThomazFB left a comment

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented May 16, 2024

The PR caused the following dependency changes:

Uh oh!

Uh oh!

Uh oh!

atorresveiga commented May 15, 2024 •

edited

Loading

wpmobilebot commented May 15, 2024 •

edited

Loading

codecov-commenter commented May 15, 2024 •

edited

Loading