-
Notifications
You must be signed in to change notification settings - Fork 132
[Woo Pos] Compose navigation template #11512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo Pos] Compose navigation template #11512
Conversation
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11512 +/- ##
============================================
- Coverage 40.82% 40.80% -0.03%
Complexity 5180 5180
============================================
Files 1070 1077 +7
Lines 62327 62358 +31
Branches 8502 8506 +4
============================================
Hits 25444 25444
- Misses 34595 34626 +31
Partials 2288 2288 ☔ View full report in Codecov by Sentry. |
…ency-setup-template-for-recording-the-navigation-graph-read-firstly-about-good-practices
fun WooPosRootHost() { | ||
val rootController = rememberNavController() | ||
|
||
NavHost( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep in mind that now even if it's just 1 screen, we still need to separate parts of the screen in easily reusable components (so probably products and cart will have their own VM, screen etc) so if potential phone support will come we can use another NavHost here and reuse the same screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Good point. Also kind of makes those classes simpler since they will be focused on doing one thing.
Found 1 violations: The PR caused the following dependency changes:expand
++--- androidx.navigation:navigation-compose -> 2.7.7 (*)
+\--- androidx.hilt:hilt-navigation-compose:1.1.0
+ +--- androidx.compose.runtime:runtime:1.0.1 -> 1.6.5 (*)
+ +--- androidx.compose.ui:ui:1.0.1 -> 1.6.5 (*)
+ +--- androidx.hilt:hilt-navigation:1.1.0 (*)
+ +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1 -> 2.6.2 (*)
+ +--- androidx.navigation:navigation-compose:2.5.1 -> 2.7.7 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
Please review and act accordingly
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any suggestions. Glad we are using Compose Navigation!
fun WooPosRootHost() { | ||
val rootController = rememberNavController() | ||
|
||
NavHost( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Good point. Also kind of makes those classes simpler since they will be focused on doing one thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes: #11495
Description
The PR:
@samiuelson @backwardstruck @jd-alexander 👋
That's more like a proposal on the approach, so feel free to propose any changes to this
Testing instructions
Images/gif
05-15--14-44.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.