Skip to content

Fix incorrect image upload error message #11493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 15, 2024

Conversation

0nko
Copy link
Contributor

@0nko 0nko commented May 13, 2024

This PR fixes the wrong private site status message for self-hosted sites, which prevents the app from uploading images.

To test:

  1. Create a self-hosted site with WooCommerce but without installing Jetpack or connecting a WP.com user using JCP
  2. Log in to the app
  3. Start creating a product
  4. Verify the image uploading is available

@0nko 0nko added the feature: product details Related to adding or editing products, includes product settings. label May 13, 2024
@0nko 0nko added this to the 18.7 milestone May 13, 2024
@0nko 0nko requested a review from hichamboushaba May 13, 2024 12:22
@0nko 0nko marked this pull request as ready for review May 13, 2024 12:22
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 13, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitdcd4c0c
Direct Downloadwoocommerce-prototype-build-pr11493-dcd4c0c.apk

@hichamboushaba hichamboushaba self-assigned this May 13, 2024
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @0nko, it works well.

Before merging this, it seems to me this is a serious bug, shouldn't we include it in the current beta version?

@0nko 0nko force-pushed the fix/image-upload-error branch from f8258be to 900d37e Compare May 14, 2024 12:42
@0nko 0nko changed the base branch from trunk to release/18.6 May 14, 2024 12:43
@0nko
Copy link
Contributor Author

0nko commented May 14, 2024

Thanks @hichamboushaba. I've rebased the branch onto release/18.6

@0nko 0nko modified the milestones: 18.7, 18.6 ❄️ May 14, 2024
@hichamboushaba hichamboushaba enabled auto-merge May 14, 2024 14:25
@hichamboushaba
Copy link
Member

hichamboushaba commented May 14, 2024

Thanks @hichamboushaba. I've rebased the branch onto release/18.6

Thanks @0nko, there is a failing unit test that's preventing the merge.

@hichamboushaba hichamboushaba merged commit 4ac28d4 into release/18.6 May 15, 2024
13 of 14 checks passed
@hichamboushaba hichamboushaba deleted the fix/image-upload-error branch May 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product details Related to adding or editing products, includes product settings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants