Add a check to avoid app crash when the products list is empty #11490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
added
type: crash
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
commented
May 13, 2024
Comment on lines
+41
to
+44
| .fetchProductList( | ||
| productFilterOptions = mapOf(ProductFilterOption.STATUS to ProductStatus.PUBLISH.value) | ||
| ).getOrNull() | ||
| ?.filterNot { it.isSampleProduct } |
There was a problem hiding this comment.
I noticed this issue while working on this, when the cached list is empty, I was fetching a new list from the API, but I was checking against the list of all products, and not just published non-sample products.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11489
Description
During the code cleanup after enabling Dynamic Dashboard feature, I removed the status
Hiddenfrom the Blaze card as it wasn't relevant anymore (the card visibility is handled by the parent ViewModel), but this has caused a crash in some cases, the testing instructions will explain those cases.Testing instructions
release/18.6.issue/11489-fix-blaze-card-crashImages/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.