Skip to content

[Dynamic Dashboard] Introduce a component to re-use as header in the filterable cards #11488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented May 10, 2024

Description

@0nko this PR introduces a simple component that we can reuse for both the reviews and orders cards, I had it already added in my branch, but since I saw that you need one also in the orders card, and you didn't add one yet, I extracted in this separate branch.

Testing instructions

Launch the preview function, and confirm it looks and behaves as expected.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba added the feature: dashboard Related to home screen project label May 10, 2024
@hichamboushaba hichamboushaba requested a review from 0nko May 10, 2024 15:09
@hichamboushaba hichamboushaba added type: task An internally driven task. status: do not merge Dependent on another PR, ready for review but not ready for merge. labels May 10, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 10, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit7c3391b
Direct Downloadwoocommerce-prototype-build-pr11488-7c3391b.apk

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 40.84%. Comparing base (5496f82) to head (7c3391b).
Report is 1 commits behind head on trunk.

Files Patch % Lines
...roid/ui/dashboard/DashboardFilterableCardHeader.kt 0.00% 73 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11488      +/-   ##
============================================
- Coverage     40.88%   40.84%   -0.05%     
  Complexity     5180     5180              
============================================
  Files          1067     1068       +1     
  Lines         62210    62283      +73     
  Branches       8484     8495      +11     
============================================
  Hits          25437    25437              
- Misses        34486    34559      +73     
  Partials       2287     2287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from dynamic-dashboard/feature-flag-m2 to trunk May 10, 2024 15:56
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I was about to do something similar! :) Looks good! 👍

@hichamboushaba hichamboushaba removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 11, 2024
@hichamboushaba hichamboushaba enabled auto-merge May 11, 2024 00:22
@hichamboushaba hichamboushaba merged commit e734909 into trunk May 11, 2024
14 of 20 checks passed
@hichamboushaba hichamboushaba deleted the dynamic-dashboard/filter-header branch May 11, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dashboard Related to home screen project type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants