Skip to content

Release shipping method selection #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2024

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented May 10, 2024

Why

This PR releases the first milestone of the Enhancing Order Shipping Lines project, which adds support for selecting a shipping method when adding/editing shipping on an order.

Description

This PR enables the Enhancing Order Shipping Lines M1 feature flag and adds the release notes.

Testing instructions

Basic testing steps:

  1. Go to the Orders tab.
  2. Create a new order and add a product, or select an existing order and tap "Edit".
  3. In the other form, tap "Add Shipping" to add a shipping line to the order, or tap "Shipping" in order totals to edit a shipping line on the order.

Scenarios to test:

  • Adding shipping to a new order.
  • Editing shipping on an existing order.
  • Removing shipping from an order.

Expected functionality:

  • The Add shipping screen allows you to select the shipping method, setting the shipping name and the shipping cost.
  • The Select shipping method screen displays all configured shipping methods in the store plus the other option
  • The Remove shipping from order button is displayed when there is an existing shipping line in the order.
  • Editing a shipping line fills the Add shipping screen with the values of the previous shipping set (shipping method, name and cost)
  • Track every time the shipping method selection changes
  • Track when a shipping line is added to the order
  • Track when the add shipping button is pressed

Images/gif

Add shipping

Screen_recording_20240509_234828.mp4

Edit shipping

Screen_recording_20240509_235243.mp4

Delete shipping

Screen_recording_20240509_235345.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: task An internally driven task. feature: order creation Related to the Order Creation feature labels May 10, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 10, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@atorresveiga atorresveiga added this to the 18.6 milestone May 10, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit4a2f874
Direct Downloadwoocommerce-prototype-build-pr11481-4a2f874.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 40.88%. Comparing base (a9a7789) to head (4a2f874).

Files Patch % Lines
...kotlin/com/woocommerce/android/util/FeatureFlag.kt 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #11481   +/-   ##
=========================================
  Coverage     40.88%   40.88%           
  Complexity     5180     5180           
=========================================
  Files          1067     1067           
  Lines         62206    62206           
  Branches       8483     8483           
=========================================
  Hits          25436    25436           
- Misses        34483    34484    +1     
+ Partials       2287     2286    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga self-assigned this May 10, 2024
@atorresveiga atorresveiga merged commit 149d27b into trunk May 10, 2024
14 checks passed
@atorresveiga atorresveiga deleted the task/release-shipping-method-selection branch May 10, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation Related to the Order Creation feature type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants