Skip to content

Shippling lines M1 analytics #11479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 10, 2024

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented May 10, 2024

Closes: #11392

Description

We want to track 3 events around shipping method selection:

Testing instructions

  1. Open the app
  2. Go to orders
  3. Tap on Create New Order (+)
  4. Add a product to enabled the add shipping button
  5. Tap on Add shipping
  6. Check that the order_add_shipping_tapped event is triggered
  7. Tap on select shipping method
  8. Select a shipping method
  9. Check that the order_shipping_method_selected event is triggered and contains the shipping_method custom property
  10. Tap on Add shipping
  11. Check that the order_shipping_method_add event is triggered and contains the shipping_method custom property

Images/gif

🔵 Tracked: order_add_shipping_tapped, Properties: {"blog_id":222408976,"is_wpcom_store":true,"was_ecommerce_trial":true,"plan_product_slug":"wooexpress-small-bundle-yearly","store_id":"b6468f83-4986-44f1-b4ce-6021649dbf29","is_debug":true,"site_url":"https:\/\/woo-practically-automatic-witch.wpcomstaging.com","cached_woo_core_version":"8.8.3"}
🔵 Tracked: order_shipping_method_selected, Properties: {"shipping_method":"free_shipping","blog_id":222408976,"is_wpcom_store":true,"was_ecommerce_trial":true,"plan_product_slug":"wooexpress-small-bundle-yearly","store_id":"b6468f83-4986-44f1-b4ce-6021649dbf29","is_debug":true,"site_url":"https:\/\/woo-practically-automatic-witch.wpcomstaging.com","cached_woo_core_version":"8.8.3"}
🔵 Tracked: order_shipping_method_add, Properties: {"flow":"creation","shipping_method":"free_shipping","blog_id":222408976,"is_wpcom_store":true,"was_ecommerce_trial":true,"plan_product_slug":"wooexpress-small-bundle-yearly","store_id":"b6468f83-4986-44f1-b4ce-6021649dbf29","is_debug":true,"site_url":"https:\/\/woo-practically-automatic-witch.wpcomstaging.com","cached_woo_core_version":"8.8.3"}

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented May 10, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 10, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit9bc78aa
Direct Downloadwoocommerce-prototype-build-pr11479-9bc78aa.apk

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.88%. Comparing base (363fa88) to head (9bc78aa).

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11479      +/-   ##
============================================
+ Coverage     40.85%   40.88%   +0.03%     
- Complexity     5177     5180       +3     
============================================
  Files          1067     1067              
  Lines         62196    62206      +10     
  Branches       8482     8483       +1     
============================================
+ Hits          25410    25436      +26     
+ Misses        34502    34483      -19     
- Partials       2284     2287       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga added feature: order creation Related to the Order Creation feature feature: analytics In-app store analytics type: task An internally driven task. labels May 10, 2024
@atorresveiga atorresveiga added this to the 18.6 milestone May 10, 2024
@atorresveiga atorresveiga added category: tracks Related to analytics, including Tracks Events. and removed feature: analytics In-app store analytics labels May 10, 2024
@atorresveiga atorresveiga marked this pull request as ready for review May 10, 2024 02:51
Alejo added 2 commits May 9, 2024 23:23
…g-lines-m1-analytics

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/creation/shipping/OrderShippingViewModel.kt
#	WooCommerce/src/test/kotlin/com/woocommerce/android/ui/orders/creation/shipping/OrderShippingViewModelTest.kt
@atorresveiga atorresveiga self-assigned this May 10, 2024
@atorresveiga atorresveiga merged commit a9a7789 into trunk May 10, 2024
14 checks passed
@atorresveiga atorresveiga deleted the issue/11392-shippling-lines-m1-analytics branch May 10, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: order creation Related to the Order Creation feature type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shipping methods tracks
4 participants