Skip to content

Select shipping method UI #11476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 9, 2024
Merged

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented May 9, 2024

Closes: #11390

Description

This PR adds the select shipping method screen and the new screen navigation and sends the selected shipping method back to the Add Shipping screen. Additionally, this PR adds two extra states to the screen: The Loading state that will be shown when the screen is fetching the shipping methods and the Error state that will be shown if the app fails to load the shipping methods.

Testing instructions

TC1

  1. Open the app
  2. Go to orders
  3. Tap on add new order (+)
  4. Tap on Add products and add a product, so the Add shipping button is enabled
  5. Tap on Add shipping
  6. Tap on select shipping method
  7. Check that the shipping methods are displayed
  8. Check that no shipping method is selected
  9. Select a shipping method
  10. Check that the app navigates back to the Add Shipping screen and the selected method is displayed on the Method section

TC2

  1. After running the TC1 tap on the Method section
  2. Check that the shipping methods are displayed
  3. Check that the expected shipping method is selected

Images/gif

Screen_recording_20240509_110645.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@atorresveiga atorresveiga added type: task An internally driven task. feature: order creation Related to the Order Creation feature labels May 9, 2024
@atorresveiga atorresveiga added this to the 18.6 milestone May 9, 2024
@atorresveiga atorresveiga self-assigned this May 9, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 9, 2024

3 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class IsSelectedProvider is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ This PR is assigned to the milestone 18.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 9, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit060cc24
Direct Downloadwoocommerce-prototype-build-pr11476-060cc24.apk

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 75.71429% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 40.83%. Comparing base (7341f58) to head (060cc24).

Files Patch % Lines
...orders/creation/shipping/OrderShippingViewModel.kt 27.27% 8 Missing ⚠️
...creation/shipping/OrderShippingMethodsViewModel.kt 86.79% 5 Missing and 2 partials ⚠️
...rs/creation/shipping/OrderShippingMethodsScreen.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11476      +/-   ##
============================================
+ Coverage     40.80%   40.83%   +0.03%     
- Complexity     5155     5165      +10     
============================================
  Files          1060     1063       +3     
  Lines         62078    62143      +65     
  Branches       8470     8472       +2     
============================================
+ Hits          25332    25379      +47     
- Misses        34466    34482      +16     
- Partials       2280     2282       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit 240b05e into trunk May 9, 2024
14 checks passed
@atorresveiga atorresveiga deleted the issue/11390-select-shipping-method-ui branch May 9, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation Related to the Order Creation feature type: task An internally driven task. unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI to support shipping method selection
4 participants