Remove Unused Drawables #11401
Merged
Remove Unused Drawables #11401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
backwardstruck
added
type: crash
|
Has there been any more progress, or plans to continue, on this @backwardstruck? |
|
@soundsokay I haven't been able to reproduce and the issue frequency is still very low. I've archived the issue until it affects an additional ten users. In the meantime, I'll get this PR ready to merge since it should be good to do anyway. It won't address the crash though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Related to: #11375
Description
The drawable
my_store_summary_header_imagewas identified as unused across the project's entire codebase and resource directories. This drawable was initially suspected to be linked to runtime exceptions on high-density devices due to its size, as indicated in issue #11375.However, upon further analysis, it was determined that this resource is not actively being used in any part of the application—neither in XML layouts nor through dynamic referencing in the code.
Testing instructions
To ensure that there are no unintended side effects from removing this drawable, please follow these testing steps:
Smoke Test: Navigate through all screens that could potentially include image resources to ensure no graphical issues are apparent.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.