-
-
Notifications
You must be signed in to change notification settings - Fork 397
Repl ssh terminal support #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wonderwhy-er
wants to merge
15
commits into
main
Choose a base branch
from
repl-ssh-terminal-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
53e5ea8
experiments with repl and terminal
wonderwhy-er d2ffa12
bit more
wonderwhy-er 38c0a6e
bit more changes
wonderwhy-er cf9ede0
Merge branch 'main' into repl-ssh-terminal-support
wonderwhy-er ac617e0
Merge remote-tracking branch 'origin/main' into repl-ssh-terminal-sup…
wonderwhy-er 6df3c2f
Updates to working with interactive processes
wonderwhy-er 2668146
Improved prompt for repls
wonderwhy-er b7d1ffc
Cleanup
wonderwhy-er e62d588
Improve chunked writing prompt
wonderwhy-er 41144d3
Improve tests
wonderwhy-er 471bc0c
Add support for negative file reads
wonderwhy-er d0f109d
Cleanup
wonderwhy-er f94f5dc
Readme updates
wonderwhy-er af885a4
Cleanup
wonderwhy-er 2652b3a
Improve work on windows
wonderwhy-er File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inconsistent error handling between handlers and underlying functions.
The handlers use
.parse()
which throws on validation errors, but the underlying functions (startProcess
,readProcessOutput
) use.safeParse()
and handle validation errors gracefully. This creates redundant validation and potential unhandled exceptions.Either use
.safeParse()
in the handlers or remove the validation from the underlying functions. Here's the recommended fix to maintain consistency:📝 Committable suggestion
🤖 Prompt for AI Agents