-
Notifications
You must be signed in to change notification settings - Fork 53
Improve standalone emulator run cli #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve standalone emulator run cli #146
Conversation
Thanks for the PR! Note that there are some formatting issues with the modified code, please run prettier to fix them. Also, note that we are not married to minimist - alternatives such as Commander.js or meow do stuff like handling |
8a6c19c
to
8a4074e
Compare
Should be fixed now, prettier did not support the
In light of this I switched over to sade which does have automatic handling of Additionally you should note that if the original |
I also applied similar changes to the |
Thanks for switching, and sorry about the long response times. Looks like the new version has some issue with |
7e60ec1
to
8a49c5d
Compare
8a49c5d
to
3d2f68e
Compare
No worries, these things happen. I have corrected the issue with |
Thanks! The serial data arrives in chunks, which do not necessarily align with line boundries. So the code needs to keep track of either the current line as it's being received, or the entire text received (could be simpler to implement), in order to make text matching work in all cases. |
Recently (in #143), the
npm start
script gained the ability to have a--image
flag passed. I believe this functionality would be quite useful as a standalone packaged program, and hence am in the process of packaging for nix.To that end, this pull request implements:
--help
and--version
flags fordemo/emulator-run.ts
to improve the general user experience from the command line.npm run build:demo
script with it's owntsconfig.demo.json
for building/running demo scripts as their own programs.