Skip to content

Additional QVariant conversions #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021
Merged

Additional QVariant conversions #145

merged 1 commit into from
May 24, 2021

Conversation

farmaazon
Copy link
Contributor

When I developed my application, I found the conversion from QPointer to QVariant necessary to make an AbstractListModel of QObjects ([an example][https://github.com/farmaazon/dombreaker-rs/blob/master/src/qt_ui/model.rs#L43]).

@ratijas
Copy link
Collaborator

ratijas commented May 24, 2021

Hi, thanks for your patch!

That impl From<QPointF> for QVariant however is not relevant to QPointer conversion in question, and also it would be a part of an upcoming #136 soon™ anyway. Do you think you could you remove it and force-push amended commit, please?

@farmaazon
Copy link
Contributor Author

Hi, thanks for your patch!

That impl From<QPointF> for QVariant however is not relevant to QPointer conversion in question, and also it would be a part of an upcoming #136 soon™ anyway. Do you think you could you remove it and force-push amended commit, please?

No problem.

@ogoffart ogoffart merged commit 9f82c5f into woboq:master May 24, 2021
@ratijas ratijas added A-wrappers Area: Wrappers and bindings C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wrappers Area: Wrappers and bindings C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants