Updated to the latest genymotion emulators #4750
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
reviewed
Apr 21, 2025
| @@ -108,7 +109,7 @@ const config = { | |||
| headless: Boolean(process.env.CI), | |||
| gpuMode: process.env.CI ? 'off' : undefined, | |||
| device: { | |||
| avdName: 'Pixel_3a_API_34' | |||
| avdName: process.env.CI ? 'Pixel_3a_API_34' : 'Pixel_3a_API_35', | |||
There was a problem hiding this comment.
Nahhh this doesn't make sense. Let's just create this emulator in advance and start using it locally.
d4vidi
reviewed
Apr 21, 2025
| @@ -149,7 +149,11 @@ export default class example extends Component { | |||
|
|
|||
| renderInnerScreen() { | |||
| const Screen = this.state.screen; | |||
| return <Screen setScreen={this.setScreen}/>; | |||
| return ( | |||
| <View style={{flex: 1, paddingTop: 24, paddingBottom: 50}}> | |||
There was a problem hiding this comment.
I don't like this direction... why can't we just listen to the insets natively and apply them? It would also prevent the unnecessary changes on iOS that technically shouldn't be here...
d4vidi
reviewed
Apr 21, 2025
| @@ -7,7 +7,7 @@ import com.wix.detox.espresso.action.common.MotionEvents | |||
| * The delay between each motion event. | |||
| * Reducing this value may fail the swipe on different devices. Please change with caution. | |||
| */ | |||
| private const val EVENT_DELAY = 25L | |||
| private const val EVENT_DELAY = 35L | |||
There was a problem hiding this comment.
Please check that this is fully backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have …