Skip to content

chore: add reusable account switcher - WPB-17805 #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 3, 2025

Conversation

dmitrysimkin
Copy link
Contributor

@dmitrysimkin dmitrysimkin commented May 29, 2025

TaskWPB-17805 [iOS] Create new account switcher modal

Issue

Added custom view for accounts switcher later to be integrated. Tests will be added later when it'll be finilized, there might be changes after integration

Testing

Screenshot 2025-05-29 at 09 53 07 Screenshot 2025-05-29 at 09 52 50

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@dmitrysimkin dmitrysimkin requested review from a team, samwyndham, jullianm and KaterinaWire and removed request for a team May 29, 2025 08:02
@dmitrysimkin dmitrysimkin requested a review from johnxnguyen May 29, 2025 08:04
Copy link
Contributor

github-actions bot commented May 29, 2025

Test Results

  2 files   56 suites   2m 7s ⏱️
162 tests 160 ✅ 1 💤 1 ❌
162 runs  161 ✅ 1 💤 0 ❌

For more details on these failures, see this check.

Results for commit 87df100.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 29, 2025

Datadog Report

Branch report: chore/add-reusable-account-switcher-wpb-17805
Commit report: 01735e6
Test service: wire-ios-mono

✅ 0 Failed, 161 Passed, 1 Skipped, 53.86s Total Time

Base automatically changed from chore/add-multibackend-lib-wpb-17925 to develop May 30, 2025 09:38
@dmitrysimkin dmitrysimkin requested a review from johnxnguyen May 30, 2025 11:52
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dmitrysimkin dmitrysimkin added this pull request to the merge queue Jun 3, 2025
Merged via the queue into develop with commit c729197 Jun 3, 2025
9 checks passed
@dmitrysimkin dmitrysimkin deleted the chore/add-reusable-account-switcher-wpb-17805 branch June 3, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants