feat: account creation type selector - WPB-17409 #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-16002c42eb22f371bd4970b460db1a2d1cc1c6bd' into feat/account-creation-type-selector-WPB-17409
…nt-creation-type-selector-WPB-17409
…t/account-creation-type-selector-WPB-17409.tmp
…t/account-creation
…t/account-creation-type-selector-WPB-17409.tmp
Test Results 4 files 359 suites 3m 58s ⏱️ For more details on these failures, see this check. Results for commit 152f790. ♻️ This comment has been updated with latest results. |
…le-accessibility-string-creation-WPB-17409
…nto feat/account-creation-type-selector-WPB-17409
caldrian
changed the base branch from
develop
to
chore/enable-accessibility-string-creation-WPB-17409
Datadog ReportBranch report: ✅ 0 Failed, 2026 Passed, 27 Skipped, 2m 4.16s Total Time |
samwyndham
approved these changes
May 28, 2025
WireAuthentication/Sources/WireAuthentication/Components/LoginViaEmailComponent.swift
Show resolved
Hide resolved
.../WireAuthenticationUI/Views/Registration/AccountTypeSelection/AccountTypeSelectionView.swift
Outdated
Show resolved
Hide resolved
Base automatically changed from
chore/enable-accessibility-string-creation-WPB-17409
to
develop
May 28, 2025 09:44
.../WireAuthenticationUI/Views/Registration/AccountTypeSelection/AccountTypeSelectionView.swift
Show resolved
Hide resolved
.../WireAuthenticationUI/Views/Registration/AccountTypeSelection/AccountTypeSelectionView.swift
Show resolved
Hide resolved
…nt-creation-type-selector-WPB-17409
KaterinaWire
approved these changes
May 28, 2025
…b.com:wireapp/wire-ios into feat/account-creation-type-selector-WPB-17409
caldrian
added a commit
that referenced
this pull request
Jun 4, 2025
This reverts commit d52552f. # Conflicts: # WireAuthentication/Sources/WireAuthenticationUI/Views/Login/LoginViaEmail/LoginViaEmailView.swift # WireAuthentication/Sources/WireAuthenticationUI/Views/Registration/AccountTypeSelection/AccountTypeSelectionView.swift # WireAuthentication/Tests/WireAuthenticationUITests/Views/Registration/AccountTypeSelection/AccountTypeSelectionViewTests.swift
6 tasks
caldrian
added a commit
that referenced
this pull request
Jun 4, 2025
This partly reverts commit d52552f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR adds the first screen of the new registration flow.
Testing
newRegistrationChecklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: