refactor: define new backend environment - WPB-12065 #3081
+136
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnxnguyen
requested review from
dmitrysimkin,
a team,
samwyndham and
jullianm
and removed request for
a team
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 70e49b3. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 276 Passed, 0 Skipped, 3s Total Time |
dmitrysimkin
approved these changes
May 27, 2025
|
|
||
| /// Create a new `BackendEnvironment`. | ||
| /// | ||
| /// - Parameters: |
There was a problem hiding this comment.
question: are url and webSocketURL intentionally skipped in the documentation?
samwyndham
approved these changes
May 30, 2025
jullianm
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In preparation for multi-backend support, this PR adds a new
BackendEnvironment2(name will change later) data structure intended to hold information about the backend endpoints and metadata. It will replace the existingBackendEnvironmentwhich will be removed at a later stage.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: