feat: batch decryption - WPB-17614 #3078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Christoph Aldrian <christoph.aldrian@wire.com> Co-authored-by: Dmitry Simkin <dzmitry.simkin.ext@wire.com> Co-authored-by: Christoph Aldrian <caldrian@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sam Wyndham <samwyndham@users.noreply.github.com> Co-authored-by: François Benaiteau <netbe@users.noreply.github.com>
caldrian
approved these changes
May 27, 2025
Test Results 6 files 655 suites 8m 12s ⏱️ For more details on these failures, see this check. Results for commit 7bd5c78. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 5329 Passed, 0 Skipped, 4m 24.71s Total Time |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
Decrypt events in batches when pulling events.
This accomplished by adding an optional
contextargument to all decryption functions. If omitted the decryption methods behave as before by opening a separate transaction for each single operation, but if it's provided the decryption operation will happen on an existing transaction context.Currently only the
PullPendingUpdateEventsSyncuse thecontextargument. We would also need to add batch decryption to the async notifications code path once it's available.Testing
App is still processing events without errors.
Non-scientific benchmark
Running on a simulator I've collected roughly 500 text messages and measured how long it took for
PullPendingUpdateEventsSyncto decrypt them all.using batch decryption
without batch decryption
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: