Skip to content

chore: review sync logging - WPB-16000 #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 3, 2025

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented May 5, 2025

TaskWPB-16000 [iOS] Review logging of sync mechanism

Issue

This PR improves logging in the new sync mechanism (V2, V3) to measure time each sync phase takes to complete with dedicated tags:

  • sync_type: initial vs incremental
  • sync_version: v1 (legacy), v2 (without async stream notifs), v3 (with async stream notifs)
  • sync_phase: pulling self user, pulling conversations, pulling feature configs..
  • duration

Similar logging was introduced for legacy sync (V1) so we can compare durations between sync versions.

Also added some new logs for the new NSE.

NEW SYNC LOGS (V2)

Screenshot 2025-05-06 at 10 47 15

Screenshot 2025-05-06 at 10 47 32

Screenshot 2025-05-06 at 10 47 52

LEGACY SYNC LOGS

Screenshot 2025-05-06 at 10 52 21

Screenshot 2025-05-06 at 10 52 39

Screenshot 2025-05-06 at 10 52 59

Testing

Describe how to test.

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@jullianm jullianm marked this pull request as ready for review May 6, 2025 09:06
@jullianm jullianm requested review from a team, netbe, samwyndham and dmitrysimkin and removed request for a team May 6, 2025 09:07
Copy link
Contributor

github-actions bot commented May 6, 2025

Test Results

   18 files  1 096 suites   10m 20s ⏱️
8 593 tests 8 561 ✅ 29 💤 3 ❌
8 605 runs  8 576 ✅ 29 💤 0 ❌

For more details on these failures, see this check.

Results for commit 213d2e6.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 6, 2025

Datadog Report

Branch report: chore/review-sync-logging
Commit report: 0d683e5
Test service: wire-ios-mono

✅ 0 Failed, 1774 Passed, 26 Skipped, 1m 56.31s Total Time

Copy link
Contributor

@dmitrysimkin dmitrysimkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left couple of minor questions

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, but I think some information should be removed from log message as it is contained in the attributes and we log attributes anyway

@samwyndham
Copy link
Contributor

Removing myself as there are already 2 reviewers. Feel free to add me back

@samwyndham samwyndham removed their request for review May 7, 2025 10:13
@jullianm jullianm changed the base branch from develop to release/cycle-3.124 May 7, 2025 15:36
@netbe netbe added the release label May 12, 2025
@jullianm jullianm requested a review from netbe May 16, 2025 15:05
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jullianm jullianm enabled auto-merge (squash) June 2, 2025 15:53
@jullianm jullianm merged commit d224898 into release/cycle-3.124 Jun 3, 2025
9 of 10 checks passed
@jullianm jullianm deleted the chore/review-sync-logging branch June 3, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants