Preserve image rotation #47
Conversation
|
Looking at the code, I'm worried that preserving the EXIF data as you are will retain location data, but I wasn't able to prove that to myself with testing. Is that something you've managed to avoid in a way that I don't understand? That's my only concern with this though, looks good otherwise :) |
|
I suspect if you wanted, you could look up the specific EXIF_TAGS values for location and explicitly remove them - I'll be honest that I didnt think of that, but that would probably be a good change to make |
|
looks like getexif() returns an instance of this class: Unsure whether the best plan is to try and create an empty one and copy the desired parts over (width, height, orientation, etc) or just strip the GPS though |
|
Yeah I would err on the side of creating an empty exif object and copying over desired pieces of data |
This is gonna be a fair bit of work to go through all of these and determine what is desireable. If you have a list of which ones are desirable I could maybe try it, but I haven't found easy examples of "create an empty exif object" within the limited time i have to make changes for backporting to TV Maybe this should be a 2-part PR, ship this (possibly with a simple GPS stripping) and move the full version to an issue for the TV team to work on at some point |
2 participants
fixes #46