Skip to content

Commit 93bd4d7

Browse files
authored
Replace gulp and tslint (#298)
* Replace gulp * Combine test and coverage steps. * Only build master branches. (Build already happens for PR) * Timeout and failure improvements. * Improve PDF parsing and testing. * Fix codecov warning. * Make config files JSON. * Cleanup. * Fix typo [skip ci]
1 parent 4a7eed4 commit 93bd4d7

21 files changed

+2055
-4122
lines changed

.appveyor.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ skip_tags: true
33

44
clone_depth: 5
55

6+
branches:
7+
only:
8+
- master
9+
610
environment:
711
matrix:
812
- nodejs_version: 16

.eslintrc.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"root": true,
3+
"parser": "@typescript-eslint/parser",
4+
"ignorePatterns": ["*.d.ts"],
5+
"plugins": [
6+
"@typescript-eslint"
7+
],
8+
"extends": [
9+
"eslint:recommended",
10+
"plugin:@typescript-eslint/recommended"
11+
]
12+
}

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jspm_packages
3737
.node_repl_history
3838

3939
# Transpiled files
40-
lib
40+
dist
4141

4242
# phpStorm files
4343
.idea

.istanbul.yml

Lines changed: 0 additions & 7 deletions
This file was deleted.

.mocharc.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"extension": ["ts"],
3+
"require": "ts-node/register",
4+
"timeout": "15000",
5+
"retries": 3
6+
}

.npmignore

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
coverage/
2-
gulpfile.js
3-
lib/test/
4-
test/
5-
tsconfig.json
6-
tslint.json
1+
.appveyor.yml
2+
.eslintrc.json
73
.istanbul.yml
4+
.mocharc.json
5+
.nyc_output/
6+
.nycrc
87
.travis.yml
98
.vscode/
9+
coverage/
10+
dist/test/
11+
test/
12+
tsconfig.json

.nycrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"reporter": ["text", "html", "json"]
3+
}

.travis.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ services:
1313
git:
1414
depth: 5
1515

16+
branches:
17+
only:
18+
- master
19+
1620
addons:
1721
chrome: stable
1822
before_install:
@@ -25,7 +29,7 @@ after_script:
2529
# - greenkeeper-lockfile-upload
2630

2731
after_success:
28-
- codecov -f coverage/coverage-remapped.json
32+
- codecov --disable=gcov -f coverage/coverage-final.json
2933

3034
language: node_js
3135
node_js:

.vscode/launch.json

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,12 @@
55
"version": "0.2.0",
66
"configurations": [
77
{
8+
"name": "Unit Tests",
89
"type": "node",
910
"request": "launch",
10-
"name": "Mocha Tests",
11-
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
12-
"args": [
13-
"--timeout",
14-
"15000",
15-
"--colors",
16-
"lib/test/**/*.js"
17-
],
18-
"outFiles": ["${workspaceRoot}/lib/**/*.js"],
19-
"internalConsoleOptions": "openOnSessionStart",
20-
"preLaunchTask": "default-build",
21-
"smartStep": true
11+
"runtimeExecutable": "npm",
12+
"runtimeArgs": ["run", "test"],
13+
"cwd": "${workspaceRoot}"
2214
},
2315
{
2416
"type": "node",

.vscode/tasks.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@
44
"version": "2.0.0",
55
"tasks": [
66
{
7-
"type": "gulp",
8-
"task": "scripts",
7+
"type": "npm",
8+
"script": "build",
9+
"problemMatcher": [
10+
"$tsc"
11+
],
912
"label": "default-build",
1013
"group": {
1114
"kind": "build",

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ HTML to PDF converter via Chrome/Chromium.
1212

1313
## Prerequisites
1414

15-
* Latest Chrome/Chromium (latest recommended, 61 or higher required but some features may not work)
15+
* Latest Chrome/Chromium
1616
* Windows, macOS, or Linux
17-
* Node.js 6 or later (we only test on 10+, mileage may vary)
17+
* A [currently supported version of Node.js](https://nodejs.org/en/about/releases/)
1818

1919
## Installation
2020

gulpfile.js

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)