Update chrome-launcher. (#297)

Author: westy92

package-lock.json

@@ -35,7 +35,7 @@
     "node": ">= 6"
   },
   "dependencies": {
-    "chrome-launcher": "0.13.2",
+    "chrome-launcher": "^0.13.4",
     "chrome-remote-interface": "^0.30.0",
     "devtools-protocol": "0.0.878340"
   },
@@ -45,8 +45,10 @@
     "@types/mocha": "^8.0.2",
     "@types/mock-fs": "^4.10.0",
     "@types/node": "^15.0.2",
+    "@types/proxyquire": "^1.3.28",
     "@types/sinon": "^10.0.0",
     "@types/sinon-chai": "^3.2.0",
+    "@types/source-map-support": "^0.5.3",
     "chai": "^4.1.0",
     "chai-string": "^1.3.0",
     "codecov": "^3.0.0",
@@ -60,9 +62,11 @@
     "mocha": "^8.1.1",
     "mock-fs": "^4.5.0",
     "pdf2json": "^1.1.7",
+    "proxyquire": "^2.1.3",
     "remap-istanbul": "^0.13.0",
     "sinon": "^10.0.0",
     "sinon-chai": "^3.0.0",
+    "source-map-support": "^0.5.19",
     "tslint": "^6.1.3",
     "tslint-microsoft-contrib": "^6.0.0",
     "typescript": "^4.1.3"

package.json

@@ -66,7 +66,7 @@ export async function create(html: string, options?: CreateOptions): Promise<Cre
 async function generate(html: string, options: CreateOptions, tab: any): Promise<CreateResult> {
   await throwIfCanceledOrFailed(options);
   const client = await CDP({ ...options, target: tab });
-  const connectionLost = new Promise<CreateResult>((_, reject) => {
+  const connectionLost = new Promise<never>((_, reject) => {
     client.on('disconnect', () => {
       options._connectionLost = true;
       reject(new Error('HtmlPdf.create() connection lost.'));

src/index.ts

@@ -2,15 +2,18 @@
 
 // tslint:disable:no-unused-expression
 
+import 'source-map-support/register';
+
 import * as chai from 'chai';
 import * as chromeLauncher from 'chrome-launcher';
 import * as Chrome from 'chrome-remote-interface/lib/chrome';
 import { Protocol } from 'devtools-protocol';
 import * as fs from 'fs';
-import getPort = require('get-port');
+import * as getPort from 'get-port';
 import * as mockFs from 'mock-fs';
 import * as path from 'path';
 import * as PDFParser from 'pdf2json';
+import * as proxyquire from 'proxyquire';
 import * as sinon from 'sinon';
 import { Readable } from 'stream';
 
@@ -87,41 +90,45 @@ describe('HtmlPdf', () => {
 
     it('should handle a Chrome launch failure', async () => {
       const error = new Error('failed!');
-      const launchStub = sinon.stub(chromeLauncher, 'launch').callsFake(() => Promise.reject(error));
       try {
-        await HtmlPdf.create('<p>hello!</p>');
+        const mockedHtmlPdf = proxyquire('../src', {
+          'chrome-launcher': {
+            launch: sinon.stub().rejects(error)
+          }
+        });
+        await mockedHtmlPdf.create('<p>hello!</p>');
         expect.fail();
       } catch (err) {
         expect(err).to.equal(error);
-      } finally {
-        launchStub.restore();
       }
     });
 
     it('should use running Chrome to generate a PDF (specify port)', async () => {
-      const launchStub = sinon.stub(chromeLauncher, 'launch');
-      try {
-        const result = await HtmlPdf.create('<p>hello!</p>', {port});
-        expect(result).to.be.an.instanceOf(HtmlPdf.CreateResult);
-        expect(launchStub).to.not.have.been.called;
-        const pdf = await getParsedPdf(result.toBuffer());
-        expect(pdf.getRawTextContent()).to.startWith('hello!');
-      } finally {
-        launchStub.restore();
-      }
+      const launchStub = sinon.stub();
+      const mockedHtmlPdf = proxyquire('../src', {
+        'chrome-launcher': {
+          launch: launchStub,
+        }
+      });
+      const result = await mockedHtmlPdf.create('<p>hello!</p>', {port});
+      expect(result).to.be.an.instanceOf(HtmlPdf.CreateResult);
+      expect(launchStub).to.not.have.been.called;
+      const pdf = await getParsedPdf(result.toBuffer());
+      expect(pdf.getRawTextContent()).to.startWith('hello!');
     });
 
     it('should use running Chrome to generate a PDF (specify host and port)', async () => {
-      const launchStub = sinon.stub(chromeLauncher, 'launch');
-      try {
-        const result = await HtmlPdf.create('<p>hello!</p>', {host: 'localhost', port});
-        expect(result).to.be.an.instanceOf(HtmlPdf.CreateResult);
-        expect(launchStub).to.not.have.been.called;
-        const pdf = await getParsedPdf(result.toBuffer());
-        expect(pdf.getRawTextContent()).to.startWith('hello!');
-      } finally {
-        launchStub.restore();
-      }
+      const launchStub = sinon.stub();
+      const mockedHtmlPdf = proxyquire('../src', {
+        'chrome-launcher': {
+          launch: launchStub,
+        }
+      });
+      const result = await mockedHtmlPdf.create('<p>hello!</p>', {host: 'localhost', port});
+      expect(result).to.be.an.instanceOf(HtmlPdf.CreateResult);
+      expect(launchStub).to.not.have.been.called;
+      const pdf = await getParsedPdf(result.toBuffer());
+      expect(pdf.getRawTextContent()).to.startWith('hello!');
     });
 
     it('should generate a PDF with Chrome options', async () => {