-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ Add ability to change tag type #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
action.yml
Outdated
if [[ "${is_scheduled:-false}" =~ [YyTt].* ]] \ | ||
&& [[ "${force_release:-false}" =~ [YyTt].* ]] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scheduled build logic condition wrongly requires force_release to be true, which contradicts the intended behavior of treating scheduled builds independent of a forced release. Consider removing the force_release check from this condition.
if [[ "${is_scheduled:-false}" =~ [YyTt].* ]] \ | |
&& [[ "${force_release:-false}" =~ [YyTt].* ]] ; then | |
if [[ "${is_scheduled:-false}" =~ [YyTt].* ]] ; then |
Copilot uses AI. Check for mistakes.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Fixes #16
Proposed Changes
Readiness Checklist
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance
closes #16