Skip to content

feat: ✨ Add ability to change tag type #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

wesley-dean
Copy link
Owner

@wesley-dean wesley-dean commented Apr 5, 2025

Fixes #16

Proposed Changes

  1. Add the ability to use schedule release tags
  2. Add logic around disabling release builds when scheduled builds are used
  3. Update documentation

Readiness Checklist

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

closes #16

@wesley-dean wesley-dean added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 5, 2025
@github-actions github-actions bot changed the title feat: Add schedule date logic and labels feat: ✨ Add ability to change tag type Apr 5, 2025
@wesley-dean wesley-dean requested a review from Copilot April 5, 2025 13:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

action.yml Outdated
Comment on lines 295 to 296
if [[ "${is_scheduled:-false}" =~ [YyTt].* ]] \
&& [[ "${force_release:-false}" =~ [YyTt].* ]] ; then
Copy link
Preview

Copilot AI Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduled build logic condition wrongly requires force_release to be true, which contradicts the intended behavior of treating scheduled builds independent of a forced release. Consider removing the force_release check from this condition.

Suggested change
if [[ "${is_scheduled:-false}" =~ [YyTt].* ]] \
&& [[ "${force_release:-false}" =~ [YyTt].* ]] ; then
if [[ "${is_scheduled:-false}" =~ [YyTt].* ]] ; then

Copilot uses AI. Check for mistakes.

Copy link
Contributor

github-actions bot commented Apr 5, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ REPOSITORY checkov yes no no 11.53s
✅ REPOSITORY gitleaks yes no no 0.06s
✅ REPOSITORY grype yes no no 21.1s
✅ REPOSITORY kics yes no no 1.19s
✅ REPOSITORY secretlint yes no no 0.92s
✅ REPOSITORY semgrep yes no no 17.58s
✅ REPOSITORY syft yes no no 1.16s
✅ REPOSITORY trivy yes no no 5.43s
✅ REPOSITORY trivy-sbom yes no no 0.06s
✅ REPOSITORY trufflehog yes no no 4.65s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@wesley-dean wesley-dean requested a review from Copilot April 5, 2025 13:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change tag type
1 participant