Refactoring - Extract buttonRendering from main initToolbar() #7819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloCkWeRX
changed the title
|
Please provide an Online Example to show this PR working, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔Type of Request
🔗Resolves an issue?
While trying to simply reverse the display order of when
columnsvssearchwas appended to the DOM in initToolbar, I found it difficult as everything was appending tohtml.Minor refactor to split out a specific sub rendering behaviour to its own thing - more could be done, just doing one chunk at a time.
📝Changelog
💡Example(s)?
☑️Self Check before Merge