Allow building on 32bit platforms #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also see #322 for the same thing |
|
Thanks for this, saved me today! |
|
Where was this tested (ie which ghc versions)? Anyway seems to fail to compile for me for ix86 though on 9.4, 9.6, and 9.8 😢 |
|
I've used 9.6.6 for |
|
Thanks for this PR, it helped me too. I don't really have access to 32bit ARM anymore, but at least on Fedora ix86 I need the following change for this PR to compile (tested with GHC 9.2, 9.4, 9.6, 9.8 and 9.10): --- cborg-0.2.10.0/src/Codec/CBOR/Magic.hs~ 2001-09-09 09:46:40.000000000 +0800
+++ cborg-0.2.10.0/src/Codec/CBOR/Magic.hs 2025-04-12 13:54:16.901381291 +0800
@@ -173,7 +173,7 @@
grabWord64 (Ptr ip#) = W64# (byteSwap# (indexWord64OffAddr# ip# 0#))
#endif
#else
-grabWord64 (Ptr ip#) = W64# (byteSwap64# (word64ToWord# (indexWord64OffAddr# ip# 0#)))
+grabWord64 (Ptr ip#) = W64# (byteSwap64# (indexWord64OffAddr# ip# 0#))
#endifAh this also agrees with the other PR https://github.com/well-typed/cborg/pull/322/files#diff-977386b4cda6ac2666d400abade9280c54b6ad875d914bb88212440cdd1145a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows cborg to be compiled on 32 bit platforms (tested on armv7l)