Reduce amount of code in AsyncPgConnection functions that have query type as generic parameter #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dullbananas
changed the title
|
Thanks for opening this PR. Do you have any hard numbers that this change actually improves compile times is any measurable way? Or is it just a general optimization that you would like to apply? |
|
The total amount of LLVM lines in the lemmy_db_schema crate reduced by 34% |
weiznich
approved these changes
Jun 11, 2024
Co-authored-by: Georg Semmler <github@weiznich.de>
weiznich
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nnethercote.github.io/perf-book/compile-times.html#llvm-ir