Skip to content

extract safari version for internal usage #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

extract safari version for internal usage #1161

merged 1 commit into from
Apr 18, 2025

Conversation

fippo
Copy link
Member

@fippo fippo commented Apr 10, 2025

so nobody has to worry about bugs in very old safari versions

Fixes #1082 with inspiration from #1127

so nobody has to worry about bugs in very old safari versions

Fixes #1082 with inspiration from #1127
@fippo fippo requested a review from dagingaa April 10, 2025 02:05
@hthetiot
Copy link

Thank you @fippo, I have lot of users in developing country on iPhone ranging from 6 to 8 stuck on iOS, between 15 and 16, i know it's a pain.

@fippo fippo merged commit db23fd3 into main Apr 18, 2025
7 checks passed
@fippo fippo deleted the safari-legacy branch April 18, 2025 16:19
@fippo
Copy link
Member Author

fippo commented Apr 18, 2025

published as v9.0.2

fippo added a commit that referenced this pull request Apr 18, 2025
which was missing the position of the match in #1161
@fippo
Copy link
Member Author

fippo commented Apr 18, 2025

well,v9.0.3. Thankfully npm lets one deprecate versions nowadays.
https://github.com/webrtcHacks/adapter/releases/tag/v8.2.4 will follow in a few days

@fippo
Copy link
Member Author

fippo commented Apr 22, 2025

and backported to v8.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari <=12.0 media establishing does not work due to removeExtmapAllowMixed shim not being applied
3 participants