Skip to content

Conversation

ldko
Copy link
Collaborator

@ldko ldko commented Sep 25, 2025

Description

This adjusts the requirements.txt file for versions of greenlet and gevent that look like they work with Python 3.12 by specifying different versions based on which Python version is installing them. Selected versions are based on the Changes lists for those packages and takes into account the httbin dependencies (httpbin now supports Python 3.12).

Motivation and Context

This is to make it minimally viable to run pywb with Python 3.12. It would fix #954.

I ran tests locally, but no matter with this requirements change or not, on various versions of python, 3 tests related to live video stuff (youtube) fail. I see these tests are marked to be skipped though when run via CI.

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue--not really a bug, but there is an issue open to address this)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed (via CI they pass, locally the same live video/youtube related tests fail for me that failed before this change).

@tw4l tw4l requested review from ikreymer and tw4l September 30, 2025 17:58
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldko , this looks great to me! Appreciate you diving in and untangling this thicket of dependencies 🎉

@tw4l tw4l merged commit 5d63370 into webrecorder:main Sep 30, 2025
4 checks passed
@axllent
Copy link

axllent commented Oct 5, 2025

@tw4l & @ikreymer would it be possible to get a new official release (including official Docker image) with this patch please? There is a critical 9.8 CVE in gevent (22.10.2) which this PR resolves with the python version bump. Thank you very much.

@tw4l
Copy link
Member

tw4l commented Oct 13, 2025

Hi @axllent, just in case you didn't see, this is now released in pywb 2.9.1: https://github.com/webrecorder/pywb/releases/tag/v-2.9.1

@axllent
Copy link

axllent commented Oct 13, 2025

Thank you @tw4l, I appreciate the heads-up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation results in Greenlet build error (Linux Mint 22.1 / Python 3.12.3)

3 participants