additional scale / browser window cleanup to properly support QA: #2663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Jun 11, 2025
ikreymer
commented
- follow up to Allow users to run crawls with 1 or 2 browser windows #2627
- use qa_num_browser_windows to set exact number of QA browsers, fallback to qa_scale
- set num_browser_windows and num_browsers_per_pod using crawler / qa values depending if QA crawl
- scale_from_browser_windows() accepts optional browsers_per_pod if dealing with possible QA override
- store 'desiredScale' in CrawlStatus to avoid recomputing for later scale resolving
- ensure status.scale is always the actual scale observed
- use qa_num_browser_windows to set exact number of QA browsers, fallback to qa_scale - set num_browser_windows and num_browsers_per_pod using crawler / qa values depending if QA crawl - scale_from_browser_windows() accepts optional browsers_per_pod if dealing with possible QA override - store 'desiredScale' in CrawlStatus to avoid recomputing for later scale resolving - ensure status.scale is always the actual scale observed
ikreymer
force-pushed
the
scale-fix-for-qa
branch
from
fe90816 to
5002aba
Compare
tw4l
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.