-
-
Notifications
You must be signed in to change notification settings - Fork 52
devex: Create and document file selection components #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f7a6777
to
53cf327
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but seeing a bug with file selection in Storybook — looking into it currently.
Oh, and a thought about FileListItem.file
— should it maybe accept Pick<File, "name" | "size">
instead of just File
?
8e08223
to
7f73cb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good!
In preparation for #2646
Changes
<btrix-file-input>
componentbtrix-file-input
Manual testing
Screenshots