Quick fix: use custom getFns for user-related keys in superadmin
#2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users are stored as a record of emails to full user objects, so we don't statically know the keys of the `orgList.users` object at fuse init time. instead, we can use `Object.values` to turn the record into an array that we can then `map` to get the desired values from the user objects.
|
Would like to get this out so it can be used internally — gonna just merge, I can't imagine this is going to break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Users are stored as a record of emails to full user objects, so we don't statically know the keys of the
orgList.usersobject at fuse init time. Instead, we can useObject.valuesto turn the record into an array that we can thenmapto get the desired values from the user objects.