Skip to content

devex: Replace inverted tooltip style with popver component #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jun 3, 2025

Resolves #2631

Changes

Replaces all instances of sl-tooltip.invert-tooltip with <btrix-popover>

Manual testing

  1. Log in as crawler
  2. Go to archived item QA review
  3. Hover over page metric chips. Verify popover renders as expected
  4. Add a note to a page
  5. Go back to "QA" section
  6. Hover over comment icon in page list. Verify popover renders
  7. Go to browser profiles and find or create profile with more than 1 site
  8. Hover over +N badge. Verify popover renders

Screenshots

Page Image/video
QA Review Screenshot 2025-06-02 at 4 41 04 PM

@SuaYoo SuaYoo requested a review from emma-sg June 3, 2025 00:29
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SuaYoo SuaYoo merged commit 580fc6d into main Jun 4, 2025
36 of 38 checks passed
@SuaYoo SuaYoo deleted the frontend-refactor-invert-tooltip branch June 4, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Replace invert-tooltip with popover component
2 participants