Skip to content

Don't clobber existing helm chart in release! #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

Don't clobber existing helm chart in release! #2643

merged 3 commits into from
Jun 3, 2025

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Jun 3, 2025 •
edited
Loading

Switch to different github release action:

Tested:

  • New draft release created (since branch ends in -release)
  • Running multiple types to ensure chart is updated in draft
  • Switching to older release to ensure chart is NOT clobbered

@ikreymer ikreymer requested review from emma-sg, SuaYoo and tw4l June 3, 2025 00:22
tw4l
tw4l approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you caught this, and thanks for the speedy fix

@ikreymer ikreymer merged commit f5c120b into main Jun 3, 2025
23 checks passed
@ikreymer ikreymer deleted the fix-chart-publish-release branch June 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

@emma-sg emma-sg Awaiting requested review from emma-sg

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Publish helm chart CI action runs on main, overrides helm chart
2 participants
@ikreymer @tw4l